You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "John Zhuge (JIRA)" <ji...@apache.org> on 2016/03/24 05:33:25 UTC
[jira] [Commented] (HADOOP-12701) Run checkstyle on test source
files
[ https://issues.apache.org/jira/browse/HADOOP-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209731#comment-15209731 ]
John Zhuge commented on HADOOP-12701:
-------------------------------------
Test the patch on Ubuntu VirtualBox VM under MacBook. Before the patch, it took 1:10.947 s to run {{mvn clean checkstyle:checkstyle}}; after the patch, the same command took 1:26.765 s.
Test the patch on MacBook. Before the patch, it took 41.425 s to run {{mvn clean checkstyle:checkstyle}}; after the patch, the same command took 50.394 s.
> Run checkstyle on test source files
> -----------------------------------
>
> Key: HADOOP-12701
> URL: https://issues.apache.org/jira/browse/HADOOP-12701
> Project: Hadoop Common
> Issue Type: Test
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Minor
> Attachments: HADOOP-12701.001.patch
>
>
> Test source files are not checked by checkstyle because Maven checkstyle plugin parameter *includeTestSourceDirectory* is *false* by default.
> Propose to enable checkstyle on test source files in order to improve the quality of unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)