You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Bill Graham (JIRA)" <ji...@apache.org> on 2009/06/20 00:46:07 UTC
[jira] Created: (HIVE-568) Driver.getSchema() throws an Exception
with partitioned tables
Driver.getSchema() throws an Exception with partitioned tables
--------------------------------------------------------------
Key: HIVE-568
URL: https://issues.apache.org/jira/browse/HIVE-568
Project: Hadoop Hive
Issue Type: Bug
Components: Clients
Reporter: Bill Graham
When doing a select all on a partitioned table, the Driver.getSchema() method throws an NPE because tableDesc isn't set on the FetchTask object. Partitioned tables have partDesc set instead of tableDesc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-568) Driver.getSchema() throws an Exception
with partitioned tables
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghotham Murthy updated HIVE-568:
----------------------------------
Assignee: Bill Graham
> Driver.getSchema() throws an Exception with partitioned tables
> --------------------------------------------------------------
>
> Key: HIVE-568
> URL: https://issues.apache.org/jira/browse/HIVE-568
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-568.patch, HIVE-568.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When doing a select all on a partitioned table, the Driver.getSchema() method throws an NPE because tableDesc isn't set on the FetchTask object. Partitioned tables have partDesc set instead of tableDesc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-568) Driver.getSchema() throws an Exception
with partitioned tables
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722096#action_12722096 ]
Raghotham Murthy commented on HIVE-568:
---------------------------------------
+1
Will commit once tests pass.
> Driver.getSchema() throws an Exception with partitioned tables
> --------------------------------------------------------------
>
> Key: HIVE-568
> URL: https://issues.apache.org/jira/browse/HIVE-568
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Reporter: Bill Graham
> Attachments: HIVE-568.patch, HIVE-568.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When doing a select all on a partitioned table, the Driver.getSchema() method throws an NPE because tableDesc isn't set on the FetchTask object. Partitioned tables have partDesc set instead of tableDesc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HIVE-568) Driver.getSchema() throws an Exception
with partitioned tables
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghotham Murthy resolved HIVE-568.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.4.0
Merged in changes along with HIVE-590 and committed. Thanks Bill!
> Driver.getSchema() throws an Exception with partitioned tables
> --------------------------------------------------------------
>
> Key: HIVE-568
> URL: https://issues.apache.org/jira/browse/HIVE-568
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Fix For: 0.4.0
>
> Attachments: HIVE-568.patch, HIVE-568.patch, input20.q.results.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When doing a select all on a partitioned table, the Driver.getSchema() method throws an NPE because tableDesc isn't set on the FetchTask object. Partitioned tables have partDesc set instead of tableDesc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-568) Driver.getSchema() throws an Exception
with partitioned tables
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722705#action_12722705 ]
Bill Graham commented on HIVE-568:
----------------------------------
I'm able to reproduce the same test failure both with and without my patch applied. I'm at svn revision 787324. Can you please remove my patch and try this test. I don't think my patch is causing this.
> Driver.getSchema() throws an Exception with partitioned tables
> --------------------------------------------------------------
>
> Key: HIVE-568
> URL: https://issues.apache.org/jira/browse/HIVE-568
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-568.patch, HIVE-568.patch, input20.q.results.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When doing a select all on a partitioned table, the Driver.getSchema() method throws an NPE because tableDesc isn't set on the FetchTask object. Partitioned tables have partDesc set instead of tableDesc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-568) Driver.getSchema() throws an Exception
with partitioned tables
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722087#action_12722087 ]
Raghotham Murthy commented on HIVE-568:
---------------------------------------
Looks good. Couple things:
1. Can you verify that the changes you are making here for show table and describe table tests are the same as in HIVE-526. If yes, can you close that jira as a duplicate?
2. There are a couple of space issues (no space after if) and typos (partion)
> Driver.getSchema() throws an Exception with partitioned tables
> --------------------------------------------------------------
>
> Key: HIVE-568
> URL: https://issues.apache.org/jira/browse/HIVE-568
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Reporter: Bill Graham
> Attachments: HIVE-568.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When doing a select all on a partitioned table, the Driver.getSchema() method throws an NPE because tableDesc isn't set on the FetchTask object. Partitioned tables have partDesc set instead of tableDesc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-568) Driver.getSchema() throws an Exception
with partitioned tables
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725242#action_12725242 ]
Bill Graham commented on HIVE-568:
----------------------------------
Just verified that the test in question fails with a fresh checkout:
svn checkout http://svn.apache.org/repos/asf/hadoop/hive/trunk hive-trunk
cd hive-trunk
ant test -Dtestcase=TestCliDriver -Dqfile=input20.q
> Driver.getSchema() throws an Exception with partitioned tables
> --------------------------------------------------------------
>
> Key: HIVE-568
> URL: https://issues.apache.org/jira/browse/HIVE-568
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-568.patch, HIVE-568.patch, input20.q.results.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When doing a select all on a partitioned table, the Driver.getSchema() method throws an NPE because tableDesc isn't set on the FetchTask object. Partitioned tables have partDesc set instead of tableDesc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-568) Driver.getSchema() throws an Exception
with partitioned tables
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghotham Murthy updated HIVE-568:
----------------------------------
Attachment: input20.q.results.txt
There was a unit test failure: input20.q
To run the specific test:
$ ant test -Dtestcase=TestCliDriver -Dqfile=input20.q
I am attaching the results of the test.
> Driver.getSchema() throws an Exception with partitioned tables
> --------------------------------------------------------------
>
> Key: HIVE-568
> URL: https://issues.apache.org/jira/browse/HIVE-568
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-568.patch, HIVE-568.patch, input20.q.results.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When doing a select all on a partitioned table, the Driver.getSchema() method throws an NPE because tableDesc isn't set on the FetchTask object. Partitioned tables have partDesc set instead of tableDesc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-568) Driver.getSchema() throws an Exception
with partitioned tables
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated HIVE-568:
-----------------------------
Attachment: HIVE-568.patch
Thanks Raghu, here's an updated patch. My show/describe table changes are the same as HIVE-526, so I'll mark that one as a duplicate.
There was one additional minor change in the HIVE-526 patch that I've incorporated into this one. A log message was moved in HiveServer.main(..).
> Driver.getSchema() throws an Exception with partitioned tables
> --------------------------------------------------------------
>
> Key: HIVE-568
> URL: https://issues.apache.org/jira/browse/HIVE-568
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Reporter: Bill Graham
> Attachments: HIVE-568.patch, HIVE-568.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When doing a select all on a partitioned table, the Driver.getSchema() method throws an NPE because tableDesc isn't set on the FetchTask object. Partitioned tables have partDesc set instead of tableDesc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-568) Driver.getSchema() throws an Exception
with partitioned tables
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated HIVE-568:
-----------------------------
Attachment: HIVE-568.patch
Please code review this patch for validity. It includes a fix, as well as a unit test that fails without the fix.
In the case where a tableDesc isn't set on the FetchTask object, I look for a partDesc. If one is found, I use the tableDesc from the first partDesc to get the deserializer. This seems like a reasonable thing to do, but please review if this logic is valid and won't cause other issues.
> Driver.getSchema() throws an Exception with partitioned tables
> --------------------------------------------------------------
>
> Key: HIVE-568
> URL: https://issues.apache.org/jira/browse/HIVE-568
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Reporter: Bill Graham
> Attachments: HIVE-568.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When doing a select all on a partitioned table, the Driver.getSchema() method throws an NPE because tableDesc isn't set on the FetchTask object. Partitioned tables have partDesc set instead of tableDesc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-568) Driver.getSchema() throws an Exception
with partitioned tables
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725252#action_12725252 ]
Raghotham Murthy commented on HIVE-568:
---------------------------------------
looks like its a problem with running this test on a mac. it seems to succeed on linux. i'll investigate this further. i'll also rerun all the tests on linux to make sure no other tests fail.
> Driver.getSchema() throws an Exception with partitioned tables
> --------------------------------------------------------------
>
> Key: HIVE-568
> URL: https://issues.apache.org/jira/browse/HIVE-568
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-568.patch, HIVE-568.patch, input20.q.results.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When doing a select all on a partitioned table, the Driver.getSchema() method throws an NPE because tableDesc isn't set on the FetchTask object. Partitioned tables have partDesc set instead of tableDesc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.