[jira] (MNG-5797) 'mvn deploy' sends HTTP User-Agent twice

["Jan Sievers (JIRA)" <ji...@codehaus.org>]

Jan Sievers created MNG-5797:
--------------------------------

             Summary: 'mvn deploy' sends HTTP User-Agent twice
                 Key: MNG-5797
                 URL: https://jira.codehaus.org/browse/MNG-5797
             Project: Maven
          Issue Type: Bug
          Components: Deployment
    Affects Versions: 3.3.1, 3.2.1
         Environment: maven 3.2.1 or later (up to 3.3.1), Java 7, Windows 7 64 bit
            Reporter: Jan Sievers
         Attachments: userAgent.zip

This may be actually a wagon-http problem but I'm opening it here since maven redistributes wagon-http.

Steps to reproduce:

Using maven 3.2.1 or later (i.e. wagon-http 2.6 or later):

# unzip attached userAgent.zip
# copy simplelogger.properties to $M2_HOME/conf/logging/ (as per [instructions|https://support.sonatype.com/entries/23656571-Configuring-Maven-HTTP-Wagon-Detailed-Logging]
# export MAVEN_OPTS="$MAVEN_OPTS -Djava.util.logging.config.file=$M2_HOME/conf/logging/simplelogger.properties"
# using pom.xml from attached userAgent.zip:

{code}
mvn -V clean deploy -DaltDeploymentRepository=id::default::<HTTP_DEPLOYMENT_URL>
{code}

you can see in the build log that HTTP header "User-Agent" is sent twice:

{code}
FINE: http-outgoing-0 >> User-Agent: Apache-Maven/3.2.1 (Java 1.7.0_67; Windows 7 6.1)
Apr 02, 2015 1:34:52 PM org.apache.maven.wagon.providers.http.httpclient.headers onRequestSubmitted
FINE: http-outgoing-0 >> User-Agent: Apache-Maven/3.2.1 (Java 1.7.0_67; Windows 7 6.1)
Apr 02, 2015 1:34:52 PM org.apache.maven.wagon.providers.http.httpclient.headers onRequestSubmitted
{code}

when using maven 3.1.1 or earlier, "User-Agent" is sent only once.

You could argue that HTTP headers are map keys and sending them twice with the same value should not hurt. However, this causes an issue when deploying to Sonatype Nexus. 

Background: Nexus uses the value of User-Agent to disambiguate deployments from multiple clients into separate staging repos. Nexus concatenates the two values instead, effectively using "<value>, <value>" as staging repo key. Not sure if this is a Nexus bug as well.





--
This message was sent by Atlassian JIRA
(v6.1.6#6162)