You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/20 06:43:30 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #600: VM Wizard: Custom RAM field compute offering
utchoang opened a new pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600
Open for https://github.com/apache/cloudstack-primate/issues/597
@rhtyd cc @svenvogel I've completed this task. Please review it. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677463488
cc @davidjumani @shwstppr
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677464143
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-678901783
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-679680073
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-679003910
@utchoang The `ComputeSelection.vue` is imported in `ScaleVM.vue`, and the MB is off. Could you fix that too ?
Or could you remove the MB entirely since MB is in the title itself ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677505345
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/600 (JID-3286)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on a change in pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#discussion_r474675600
##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -21,31 +21,20 @@
<a-row>
<a-col :md="colContraned" :lg="colContraned">
<a-form-item
- :label="this.$t('label.cpunumber')"
+ :label="$t('label.cpunumber')"
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
- <a-slider
- :min="minCpu"
- :max="maxCpu"
- v-model="cpuNumberInputValue"
- @change="($event) => updateComputeCpuNumber($event)"
- />
Review comment:
Sliders are certainly much more usefulthan the up/down arrows (makes clicking from 1MB to 8192 a bit of pain :) )
(assuming it doesn't complicate things due to difference between min/max "values" for the slider - as we custom unconstrained and constrained offerings (need to know min/max values for the slider)
##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -21,31 +21,20 @@
<a-row>
<a-col :md="colContraned" :lg="colContraned">
<a-form-item
- :label="this.$t('label.cpunumber')"
+ :label="$t('label.cpunumber')"
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
- <a-slider
- :min="minCpu"
- :max="maxCpu"
- v-model="cpuNumberInputValue"
- @change="($event) => updateComputeCpuNumber($event)"
- />
Review comment:
Sliders are certainly much more useful than the up/down arrows (makes clicking from 1MB to 8192 a bit of pain :) )
(assuming it doesn't complicate things due to difference between min/max "values" for the slider - as we custom unconstrained and constrained offerings (need to know min/max values for the slider)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-678265314
@utchoang can you resolve conflicts? thnx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-678793896
@davidjumani can you assist Hoang or send a PR based on this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#discussion_r473791803
##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -21,31 +21,21 @@
<a-row>
<a-col :md="colContraned" :lg="colContraned">
<a-form-item
- :label="this.$t('label.cpunumber')"
+ :label="$t('label.cpunumber')"
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
- <a-slider
- :min="minCpu"
- :max="maxCpu"
- v-model="cpuNumberInputValue"
- @change="($event) => updateComputeCpuNumber($event)"
- />
- </a-col>
- <a-col :md="4" :lg="4">
- <a-input-number
- v-model="cpuNumberInputValue"
- :formatter="value => `${value}`"
- @change="($event) => updateComputeCpuNumber($event)"
- />
- </a-col>
+ <a-input-number
+ v-model="cpuNumberInputValue"
+ :formatter="value => `${value}`"
Review comment:
@utchoang Is this needed ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-678904339
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/600 (JID-3356)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677500151
Ping @shwstppr - can you check review the changes
@davidjumani can you test the cases for (a) normal offering, (b) contrainst offering, (c) uncontr... offering; also test the deploy VM and change service offering for a VM actions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-679681627
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-679703486
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/600 (JID-3368)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-678901558
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#discussion_r474673665
##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -21,31 +21,20 @@
<a-row>
<a-col :md="colContraned" :lg="colContraned">
<a-form-item
- :label="this.$t('label.cpunumber')"
+ :label="$t('label.cpunumber')"
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
- <a-slider
- :min="minCpu"
- :max="maxCpu"
- v-model="cpuNumberInputValue"
- @change="($event) => updateComputeCpuNumber($event)"
- />
Review comment:
@andrijapanicsb would it be a better UX to hide / show the sliders for offerings with a range ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#discussion_r474665581
##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -21,31 +21,20 @@
<a-row>
<a-col :md="colContraned" :lg="colContraned">
<a-form-item
- :label="this.$t('label.cpunumber')"
+ :label="$t('label.cpunumber')"
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
- <a-slider
- :min="minCpu"
- :max="maxCpu"
- v-model="cpuNumberInputValue"
- @change="($event) => updateComputeCpuNumber($event)"
- />
Review comment:
if it's a duplicate element than you may decide, otherwise can you consult with @andrijapanicsb (from a UX point of view)? @davidjumani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677500204
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677632936
@rhtyd tried to test deployment with different constrained and unconstrained offerings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-678261965
@davidjumani can you advise here or raise a PR using Hoang's PR and send a PR cc @nvazquez @andrijapanicsb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-679003910
@utchoang The `ComputeSelection.vue` is imported in `ScaleVM.vue`, and the MB is off. Could you fix that too ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#discussion_r474660879
##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -21,31 +21,20 @@
<a-row>
<a-col :md="colContraned" :lg="colContraned">
<a-form-item
- :label="this.$t('label.cpunumber')"
+ :label="$t('label.cpunumber')"
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
- <a-slider
- :min="minCpu"
- :max="maxCpu"
- v-model="cpuNumberInputValue"
- @change="($event) => updateComputeCpuNumber($event)"
- />
Review comment:
@rhtyd is it okay to remove the slider ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#discussion_r474644989
##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -21,31 +21,20 @@
<a-row>
<a-col :md="colContraned" :lg="colContraned">
<a-form-item
- :label="this.$t('label.cpunumber')"
+ :label="$t('label.cpunumber')"
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
- <a-slider
- :min="minCpu"
- :max="maxCpu"
- v-model="cpuNumberInputValue"
- @change="($event) => updateComputeCpuNumber($event)"
- />
Review comment:
@davidjumani No problem. But in my opinion, it is not really necessary the same as Root Disk Size in the template section not using the slider.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#discussion_r473805327
##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -21,31 +21,21 @@
<a-row>
<a-col :md="colContraned" :lg="colContraned">
<a-form-item
- :label="this.$t('label.cpunumber')"
+ :label="$t('label.cpunumber')"
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
- <a-slider
- :min="minCpu"
- :max="maxCpu"
- v-model="cpuNumberInputValue"
- @change="($event) => updateComputeCpuNumber($event)"
- />
- </a-col>
- <a-col :md="4" :lg="4">
- <a-input-number
- v-model="cpuNumberInputValue"
- :formatter="value => `${value}`"
- @change="($event) => updateComputeCpuNumber($event)"
- />
- </a-col>
+ <a-input-number
+ v-model="cpuNumberInputValue"
+ :formatter="value => `${value}`"
Review comment:
@davidjumani No need. I've removed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677500947
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677494429
@rhtyd Good to go! Thanks @utchoang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677470075
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/600 (JID-3283)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#discussion_r474558910
##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -21,31 +21,20 @@
<a-row>
<a-col :md="colContraned" :lg="colContraned">
<a-form-item
- :label="this.$t('label.cpunumber')"
+ :label="$t('label.cpunumber')"
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
- <a-slider
- :min="minCpu"
- :max="maxCpu"
- v-model="cpuNumberInputValue"
- @change="($event) => updateComputeCpuNumber($event)"
- />
Review comment:
@utchoang Does keeping the sliders break anything ?
##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -21,31 +21,20 @@
<a-row>
<a-col :md="colContraned" :lg="colContraned">
<a-form-item
- :label="this.$t('label.cpunumber')"
+ :label="$t('label.cpunumber')"
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
- <a-slider
- :min="minCpu"
- :max="maxCpu"
- v-model="cpuNumberInputValue"
- @change="($event) => updateComputeCpuNumber($event)"
- />
Review comment:
@utchoang Do keeping the sliders break anything ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #600: VM Wizard: Custom RAM field compute offering
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-678274094
@shwstppr #594 probably fixed the issue you faced. Could you try on latest master ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org