[GitHub] [beam] udim commented on a change in pull request #15605: [BEAM-9487] Revert changes from PR15340 to be applied in next version

[GitBox <gi...@apache.org>]

udim commented on a change in pull request #15605:
URL: https://github.com/apache/beam/pull/15605#discussion_r717833206



##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -2332,19 +2332,22 @@ def expand(self, pcoll):
 
     unsafe_reason = trigger.may_lose_data(windowing)
     if unsafe_reason != DataLossReason.NO_POTENTIAL_LOSS:
-      reason_msg = str(unsafe_reason).replace('DataLossReason.', '')
       if pcoll.pipeline.allow_unsafe_triggers:
+        # TODO(BEAM-9487): Switch back to this log for Beam 2.33.
+        # _LOGGER.warning(
+        #   'Skipping trigger safety check. '
+        #   'This could lead to incomplete or missing groups.')
         _LOGGER.warning(
-            '%s: Unsafe trigger `%s` detected (reason: %s). This is '
-            'being allowed because --allow_unsafe_triggers is set. This could '
-            'lead to missing or incomplete groups.',
+            '%s: Unsafe trigger type (%s) detected. Starting with '
+            'Beam 2.33, this will raise an error by default. '

Review comment:
       same

##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -2320,10 +2320,10 @@ def expand(self, pcoll):
       if pcoll.pipeline.allow_unsafe_triggers:
         # TODO(BEAM-9487) Change comment for Beam 2.33
         _LOGGER.warning(
-            '%s: PCollection passed to GroupByKey is unbounded, has a global '
-            'window, and uses a default trigger. This is being allowed '
-            'because --allow_unsafe_triggers is set, but it may prevent '
-            'data from making it through the pipeline.',
+            'PCollection passed to GroupByKey (label: %s) is unbounded, has a '
+            'global window, and uses a default trigger. This will no longer '
+            'be allowed starting with Beam 2.33 unless '

Review comment:
       2.34




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org