You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/10 19:28:45 UTC

[GitHub] [pulsar] BewareMyPower opened a new pull request #8905: [C++] Add consumer's configs for reader

BewareMyPower opened a new pull request #8905:
URL: https://github.com/apache/pulsar/pull/8905


   ### Motivation
   
   C++ reader cannot set some consumer's configs. Like `CryptoReader`, if the config is not supported for reader, then reader cannot decrypt encrypted messages. Also, reader cannot set other configs like `AckGroupingTimeMs`  so that reader cannot control the behavior of `AckGroupingTracker`.
   
   ### Modifications
   
   - Add other consumer's configs for reader, except:
       - NegativeAckRedeliveryDelayMs: reader has no chance to call `negativeAcknowledge`
       - BrokerConsumerStatsCacheTimeInMs: reader has no chance to call `getBrokerConsumerStatsAsync`
       - KeySharedPolicy and ConsumerType: reader only supports Exclusive subscription now
       - MaxTotalReceiverQueueSizeAcrossPartitions: reader doesn't support partitioned topics now
       - PatternAutoDiscoveryPeriod: reader doesn't support regex subscription now
   - Add some fields to get the consumer config before reader's internal consumer is created, then add some unit tests for the consumer config.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
     - Run `ReaderConfigurationTest`
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (**yes**)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (docs)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8905: [C++] Add consumer's configs for reader

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8905:
URL: https://github.com/apache/pulsar/pull/8905#issuecomment-742899215


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #8905: [C++] Add consumer's configs for reader

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8905:
URL: https://github.com/apache/pulsar/pull/8905


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8905: [C++] Add consumer's configs for reader

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8905:
URL: https://github.com/apache/pulsar/pull/8905#issuecomment-742971098


   @sijie @jiazhai @merlimat PTAL


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8905: [C++] Add consumer's configs for reader

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8905:
URL: https://github.com/apache/pulsar/pull/8905#issuecomment-742953352


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org