svn commit: r663201 - /incubator/log4php/trunk/src/main/php/config/LoggerPropertySetter.php

[ca...@apache.org]

Author: carnold
Date: Wed Jun  4 08:25:32 2008
New Revision: 663201

URL: http://svn.apache.org/viewvc?rev=663201&view=rev
Log:
LOG4PHP-14: LoggerPropertySetter: warnings about is_a() and a non-static method

Modified:
    incubator/log4php/trunk/src/main/php/config/LoggerPropertySetter.php

Modified: incubator/log4php/trunk/src/main/php/config/LoggerPropertySetter.php
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/config/LoggerPropertySetter.php?rev=663201&r1=663200&r2=663201&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/config/LoggerPropertySetter.php (original)
+++ incubator/log4php/trunk/src/main/php/config/LoggerPropertySetter.php Wed Jun  4 08:25:32 2008
@@ -83,7 +83,7 @@
      * @param string $prefix Only keys having the specified prefix will be set.
      * @static
      */
-    function setPropertiesByObject(&$obj, $properties, $prefix)
+    public static function setPropertiesByObject(&$obj, $properties, $prefix)
     {
         $pSetter = new LoggerPropertySetter($obj);
         return $pSetter->setProperties($properties, $prefix);
@@ -108,7 +108,7 @@
                     continue;
                 $value = LoggerOptionConverter::findAndSubst($key, $properties);
                 $key = substr($key, $len);
-                if ($key == 'layout' and is_a($this->obj, 'loggerappender')) {
+                if ($key == 'layout' and ($this->obj instanceof LoggerAppender)) {
                     continue;
                 }
                 $this->setProperty($key, $value);