[incubator-superset] branch master updated: [migration]clean up __from and __to parameters in dashboard json_metadata (#6378)

[gr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new c42bcf8  [migration]clean up __from and __to parameters in dashboard json_metadata (#6378)
c42bcf8 is described below

commit c42bcf81bc51bd5ef8d214a1a2036ab781ddb5c9
Author: Grace Guo <gr...@airbnb.com>
AuthorDate: Fri Nov 16 11:03:22 2018 -0800

    [migration]clean up __from and __to parameters in dashboard json_metadata (#6378)
---
 ...08545_migrate_time_range_for_default_filters.py | 96 ++++++++++++++++++++++
 1 file changed, 96 insertions(+)

diff --git a/superset/migrations/versions/4ce8df208545_migrate_time_range_for_default_filters.py b/superset/migrations/versions/4ce8df208545_migrate_time_range_for_default_filters.py
new file mode 100644
index 0000000..4d04817
--- /dev/null
+++ b/superset/migrations/versions/4ce8df208545_migrate_time_range_for_default_filters.py
@@ -0,0 +1,96 @@
+"""empty message
+
+Revision ID: 4ce8df208545
+Revises: 55e910a74826
+Create Date: 2018-11-12 13:31:07.578090
+
+"""
+
+# revision identifiers, used by Alembic.
+import json
+
+from alembic import op
+from sqlalchemy import (
+    Column,
+    Integer,
+    Text,
+)
+from sqlalchemy.ext.declarative import declarative_base
+
+from superset import db
+
+revision = '4ce8df208545'
+down_revision = '55e910a74826'
+
+Base = declarative_base()
+
+
+class Dashboard(Base):
+    """Declarative class to do query in upgrade"""
+    __tablename__ = 'dashboards'
+    id = Column(Integer, primary_key=True)
+    json_metadata = Column(Text)
+
+
+def upgrade():
+    bind = op.get_bind()
+    session = db.Session(bind=bind)
+
+    dashboards = session.query(Dashboard).all()
+    for i, dashboard in enumerate(dashboards):
+        print('scanning dashboard ({}/{}) >>>>'.format(i + 1, len(dashboards)))
+        if dashboard.json_metadata:
+            json_metadata = json.loads(dashboard.json_metadata)
+            has_update = False
+
+            # default_filters: it may define time_range filter
+            default_filters = json_metadata.get('default_filters')
+            if default_filters and default_filters != '{}':
+                try:
+                    filters = json.loads(default_filters)
+                    keys = [key for key, val in filters.items() if
+                            val.get('__from') or val.get('__to')]
+                    if len(keys):
+                        for key in keys:
+                            val = filters[key]
+                            __from = val.pop('__from', '')
+                            __to = val.pop('__to', '')
+                            # if user already defined __time_range,
+                            # just abandon __from and __to
+                            if '__time_range' not in val:
+                                val['__time_range'] = '{} : {}'.format(__from, __to)
+                        json_metadata["default_filters"] = json.dumps(filters)
+                        has_update = True
+                except Exception:
+                    pass
+
+            # filter_immune_slice_fields:
+            # key: chart id, value: field names that escape from filters
+            filter_immune_slice_fields = json_metadata.get('filter_immune_slice_fields')
+            if filter_immune_slice_fields:
+                keys = [key for key, val in filter_immune_slice_fields.items() if
+                        '__from' in val or '__to' in val]
+                if len(keys):
+                    for key in keys:
+                        val = filter_immune_slice_fields[key]
+                        if '__from' in val:
+                            val.remove('__from')
+                        if '__to' in val:
+                            val.remove('__to')
+                        # if user already defined __time_range,
+                        # just abandon __from and __to
+                        if '__time_range' not in val:
+                            val.append('__time_range')
+                    json_metadata['filter_immune_slice_fields'] = \
+                        filter_immune_slice_fields
+                    has_update = True
+
+            if has_update:
+                dashboard.json_metadata = json.dumps(json_metadata)
+
+    session.commit()
+    session.close()
+
+
+def downgrade():
+    pass