[GitHub] [sling-org-apache-sling-discovery-base] kwin commented on a diff in pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

[GitBox <gi...@apache.org>]

kwin commented on code in PR #7:
URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#discussion_r923498422


##########
src/main/java/org/apache/sling/discovery/base/connectors/announcement/CachedAnnouncement.java:
##########
@@ -43,7 +43,7 @@ public class CachedAnnouncement {
 
     private final BaseConfig config;
     
-    CachedAnnouncement(final Announcement announcement, final BaseConfig config) {

Review Comment:
   if this has always been package protected I guess there is no need to export this either.



##########
src/main/java/org/apache/sling/discovery/base/connectors/ping/TopologyConnectorClient.java:
##########
@@ -112,9 +112,9 @@ public class TopologyConnectorClient implements
     /** SLING-3382: unix-time at which point the backoff-period ends and pings can be sent again **/
     private long backoffPeriodEnd = -1;
     
-    TopologyConnectorClient(final ClusterViewService clusterViewService,

Review Comment:
   if this has always been package protected I guess there is no need to export this either.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org