You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by rmannibucau <gi...@git.apache.org> on 2017/12/05 11:10:58 UTC
[GitHub] maven-wagon pull request #37: making the retry handle of http client configu...
GitHub user rmannibucau opened a pull request:
https://github.com/apache/maven-wagon/pull/37
making the retry handle of http client configurable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmannibucau/maven-wagon fb/configurable-http-retry-policy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-wagon/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit c83997d712d31a2148e23aaae3e5604f4452f889
Author: Romain Manni-Bucau <rm...@gmail.com>
Date: 2017-12-05T11:10:34Z
making the retry handle of http client configurable
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #37: making the retry handle of http client configurable
Posted by rmannibucau <gi...@git.apache.org>.
Github user rmannibucau commented on the issue:
https://github.com/apache/maven-wagon/pull/37
Small misunderstanding: default behavior is the current one but default (same for standard) clasq value actually references the name of the impl -
with a shortname to be human feiendly - and default impl supports retryable exception classes configuration.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #37: making the retry handle of http client configurable
Posted by rmannibucau <gi...@git.apache.org>.
Github user rmannibucau commented on the issue:
https://github.com/apache/maven-wagon/pull/37
I guess
-Dmaven.wagon.http.retryhandler.class=default
-Dmaven.wagon.http.retryhandler.nonRetryableClasses=java.net.UnknownHostException
can be a good start
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #37: making the retry handle of http client configurable
Posted by olamy <gi...@git.apache.org>.
Github user olamy commented on the issue:
https://github.com/apache/maven-wagon/pull/37
interesting feature. I wonder you could add some documentation maybe here: http://maven.apache.org/wagon/wagon-providers/wagon-http/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #37: making the retry handle of http client configurable
Posted by rmannibucau <gi...@git.apache.org>.
Github user rmannibucau commented on the issue:
https://github.com/apache/maven-wagon/pull/37
@jkff default didnt change (backwd compat but open to suggestions)
idea is to add system properties to maven (MAVEN_OPTS). Here are some samples:
-Dmaven.wagon.http.retryhandler.class=default
-Dmaven.wagon.http.retryhandler.count=5
-Dmaven.wagon.http.retryhandler.requestSentEnabled=false #default
-Dmaven.wagon.http.retryhandler.nonRetryableClasses=javax.net.ssl.SSLException,java.net.UnknownHostException
Note that `-Dmaven.wagon.http.retryhandler.class=default` can be switched to `-Dmaven.wagon.http.retryhandler.class=standard` to use the standard retry handler impl. using a fqn class name of a http retry handler it will replace the default impl with your custom class (you must add the jar to maven libs).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #37: making the retry handle of http client configurable
Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the issue:
https://github.com/apache/maven-wagon/pull/37
There is bit of a chaos now. I know that the Deploy Plugin supports something similar and people are requesting the same feature for this problem area. I'll collect and have a look at it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #37: making the retry handle of http client configurable
Posted by jkff <gi...@git.apache.org>.
Github user jkff commented on the issue:
https://github.com/apache/maven-wagon/pull/37
Very nice! Could you comment more on how to use this in practice to improve reliability w.r.t. common network issues? Is the default behavior changed?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #37: making the retry handle of http client configurable
Posted by jkff <gi...@git.apache.org>.
Github user jkff commented on the issue:
https://github.com/apache/maven-wagon/pull/37
I see. So, for example, what's the shortest way to configure this to simply retry everything, including socket exceptions, host resolution exceptions etc? (what we want in Beam builds when downloading artifacts) Would it be `-Dmaven.wagon.http.retryhandler.class=standard` ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #37: making the retry handle of http client configurable
Posted by rmannibucau <gi...@git.apache.org>.
Github user rmannibucau commented on the issue:
https://github.com/apache/maven-wagon/pull/37
@olamy updated site apt
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-wagon issue #37: making the retry handle of http client configurable
Posted by jkff <gi...@git.apache.org>.
Github user jkff commented on the issue:
https://github.com/apache/maven-wagon/pull/37
Wait: the default one would give current behavior, which doesn't retry on socket errors. Did you mean `-Dmaven.wagon.http.retryhandler.class=standard` perhaps, and without the `nonRetryableClasses` argument (cause I'd prefer UnknownHost to also be retried, it can happen due to transient network issues)?
It's a bit confusing that `default` and `standard` have such different meanings...
Anyway: hope that some of the maintainers can chime in perhaps?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org