You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/05 05:38:16 UTC
[GitHub] [dubbo-go-hessian2] zonghaishang opened a new pull request #197: More unit tests
zonghaishang opened a new pull request #197:
URL: https://github.com/apache/dubbo-go-hessian2/pull/197
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks merged pull request #197: More unit tests
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #197:
URL: https://github.com/apache/dubbo-go-hessian2/pull/197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on a change in pull request #197: More unit tests
Posted by GitBox <gi...@apache.org>.
wongoo commented on a change in pull request #197:
URL: https://github.com/apache/dubbo-go-hessian2/pull/197#discussion_r435703469
##########
File path: string_test.go
##########
@@ -158,17 +159,29 @@ func TestStringEncode(t *testing.T) {
testJavaDecode(t, "argString_65536", s65560[:65536])
}
-func BenchmarkDecodeStringOptimized(t *testing.B) {
+var decodePool = &sync.Pool{
Review comment:
the pool seems only being used once, is it necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #197: More unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #197:
URL: https://github.com/apache/dubbo-go-hessian2/pull/197#issuecomment-639271414
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=h1) Report
> Merging [#197](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/9ab1067e2217ca03823370b439db88f9514137db&el=desc) will **increase** coverage by `0.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 66.01% 66.39% +0.38%
==========================================
Files 22 22
Lines 2845 2845
==========================================
+ Hits 1878 1889 +11
+ Misses 749 740 -9
+ Partials 218 216 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `68.37% <0.00%> (+1.70%)` | :arrow_up: |
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `57.97% <0.00%> (+2.60%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=footer). Last update [9ab1067...de51a6d](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter commented on pull request #197: More unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #197:
URL: https://github.com/apache/dubbo-go-hessian2/pull/197#issuecomment-639271414
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=h1) Report
> Merging [#197](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/9ab1067e2217ca03823370b439db88f9514137db&el=desc) will **increase** coverage by `0.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 66.01% 66.39% +0.38%
==========================================
Files 22 22
Lines 2845 2845
==========================================
+ Hits 1878 1889 +11
+ Misses 749 740 -9
+ Partials 218 216 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `68.37% <0.00%> (+1.70%)` | :arrow_up: |
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `57.97% <0.00%> (+2.60%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=footer). Last update [9ab1067...a0b0047](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/197?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] zonghaishang commented on a change in pull request #197: More unit tests
Posted by GitBox <gi...@apache.org>.
zonghaishang commented on a change in pull request #197:
URL: https://github.com/apache/dubbo-go-hessian2/pull/197#discussion_r435705574
##########
File path: string_test.go
##########
@@ -158,17 +159,29 @@ func TestStringEncode(t *testing.T) {
testJavaDecode(t, "argString_65536", s65560[:65536])
}
-func BenchmarkDecodeStringOptimized(t *testing.B) {
+var decodePool = &sync.Pool{
Review comment:
This is used to test pooling decoding and improve code coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org