You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "woaishixiaoxiao (via GitHub)" <gi...@apache.org> on 2026/09/02 12:15:12 UTC
[PR] Tiered storage cannot dispatch messages larger than the group commit size [rocketmq]
woaishixiaoxiao opened a new pull request, #10999:
URL: https://github.com/apache/rocketmq/pull/10999
### Which Issue(s) This PR Fixes
- Fixes #<10998>
### Brief Description
The tiered storage dispatcher checks the accumulated batch size before
appending the current message. When the first message size is equal to or
larger than `tieredStoreGroupCommitSize`, the dispatch loop exits with an
empty dispatch request list.
As a result, no commit is triggered and the tiered consume queue offset
does not advance. The dispatcher repeatedly retries the same message,
preventing it and subsequent messages from being archived.
This change ensures that at least one message is included in each dispatch
batch. A message that reaches or exceeds the group commit size is dispatched
as a single-message batch.
A regression test has also been added to verify that the tiered consume
queue offset advances when a message size equals the configured group
commit size.
### How Did You Test This Change?
1. Added `dispatchMessageAtGroupCommitSizeTest` to reproduce the issue.
Before the fix, the test timed out because the consume queue offset
remained at 100 instead of advancing to 101.
2. Verified the regression test after the fix:
`mvn -pl tieredstore -Dtest=MessageStoreDispatcherImplTest#dispatchMessageAtGroupCommitSizeTest test`
3. Ran the complete tiered storage module test suite:
`mvn -pl tieredstore test`
Result: 128 tests run, 0 failures, 0 errors, 0 skipped.
4. Checkstyle and SpotBugs validation also completed successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #10998] Fix Tiered storage cannot dispatch messages larger than the group commit size [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10999:
URL: https://github.com/apache/rocketmq/pull/10999#issuecomment-5509732622
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10999?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.54%. Comparing base ([`669a2e1`](https://app.codecov.io/gh/apache/rocketmq/commit/669a2e180e953af5484e77738a83ba7ed954f619?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f0f6ff8`](https://app.codecov.io/gh/apache/rocketmq/commit/f0f6ff8371a42b7a4b7bcf13fe58df53f81bc25d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/10999?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...q/tieredstore/core/MessageStoreDispatcherImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/10999?src=pr&el=tree&filepath=tieredstore%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Ftieredstore%2Fcore%2FMessageStoreDispatcherImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL2NvcmUvTWVzc2FnZVN0b3JlRGlzcGF0Y2hlckltcGwuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10999?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #10999 +/- ##
=============================================
- Coverage 48.61% 48.54% -0.08%
+ Complexity 13681 13663 -18
=============================================
Files 1381 1381
Lines 101480 101480
Branches 13190 13190
=============================================
- Hits 49332 49259 -73
- Misses 46144 46198 +54
- Partials 6004 6023 +19
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/10999?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org