You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "mattcasters (via GitHub)" <gi...@apache.org> on 2026/10/15 09:11:27 UTC
[PR] Issue #8942 : Don't mark generated SQL as changed (hop)
mattcasters opened a new pull request, #8944:
URL: https://github.com/apache/hop/pull/8944
Generated DDL and suggested SQL (the SQL button on a transform or action, Generate DDL, `SELECT`, truncate) open in the database SQL editor without marking the tab changed. Closing the tab no longer asks to save text the user did not type. Editing the script still marks it changed.
The caret is placed on the last line of the generated script. Focus moves to the editor after the shell activates, so it does not stay in the tree filter.
fixes #8942
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #8942 : Don't mark generated SQL as changed (hop)
Posted by "bamaer (via GitHub)" <gi...@apache.org>.
bamaer merged PR #8944:
URL: https://github.com/apache/hop/pull/8944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #8942 : Don't mark generated SQL as changed (hop)
Posted by "bamaer (via GitHub)" <gi...@apache.org>.
bamaer commented on PR #8944:
URL: https://github.com/apache/hop/pull/8944#issuecomment-6198375694
LGTM. Checked that every generated-SQL path (Generate DDL, SELECT, and the transform/action SQL buttons via `DatabaseWorkbenchDialog.openSql`) now goes through `openGeneratedSql` and opens clean, and that typing still marks the tab changed. Code reviewed, not run locally; CI is green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org