You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/18 15:08:52 UTC

[GitHub] [superset] kgabryje commented on a change in pull request #18790: [WIP] chore(native-filters): Remove cascading popovers from filter bar

kgabryje commented on a change in pull request #18790:
URL: https://github.com/apache/superset/pull/18790#discussion_r810084565



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/state.ts
##########
@@ -20,30 +20,28 @@ import { useMemo } from 'react';
 import { useSelector } from 'react-redux';
 import {
   DataMaskStateWithId,
+  ensureIsArray,
   ExtraFormData,
-  NativeFiltersState,
 } from '@superset-ui/core';
 import { mergeExtraFormData } from '../../utils';
 
 // eslint-disable-next-line import/prefer-default-export
-export function useCascadingFilters(
+export function useFilterDependencies(
   id: string,
   dataMaskSelected?: DataMaskStateWithId,
 ): ExtraFormData {
-  const { filters } = useSelector<any, NativeFiltersState>(
-    state => state.nativeFilters,
+  const parentIds = useSelector<any, string[] | undefined>(

Review comment:
       👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org