You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "GNK48-Ava (via GitHub)" <gi...@apache.org> on 2023/11/11 13:18:03 UTC
[PR] [type:test][ISSUE #5278] add unit test for shenyu-discovery-etcd [shenyu]
GNK48-Ava opened a new pull request, #5291:
URL: https://github.com/apache/shenyu/pull/5291
<!-- Describe your PR here; e.g. Fixes #5278 -->
#5278
### finished the unit test for the discovery-etcd
- org.apache.shenyu.discovery.etcd.EtcdDiscoveryService
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [X] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [X] You submit test cases (unit or integration tests) that back your changes.
- [X] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:test][ISSUE #5278] add unit test for shenyu-discovery-etcd [shenyu]
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind merged PR #5291:
URL: https://github.com/apache/shenyu/pull/5291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:test][ISSUE #5278] add unit test for shenyu-discovery-etcd [shenyu]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5291:
URL: https://github.com/apache/shenyu/pull/5291#issuecomment-1807387370
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5291?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5291](https://app.codecov.io/gh/apache/shenyu/pull/5291?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b1e6361) into [master](https://app.codecov.io/gh/apache/shenyu/commit/077f889fad946b77fe3f56b69c5596076d0b4a60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (077f889) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #5291 +/- ##
============================================
- Coverage 61.65% 61.64% -0.01%
- Complexity 8788 8802 +14
============================================
Files 1262 1263 +1
Lines 38780 38873 +93
Branches 3701 3709 +8
============================================
+ Hits 23908 23965 +57
- Misses 12765 12790 +25
- Partials 2107 2118 +11
```
[see 5 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5291/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:test][ISSUE #5278] add unit test for shenyu-discovery-etcd [shenyu]
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on PR #5291:
URL: https://github.com/apache/shenyu/pull/5291#issuecomment-1807377386
pls add my wechat: yijia1949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org