You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/04/21 10:24:00 UTC

[jira] [Commented] (PARQUET-1844) Removed Hadoop transitive dependency on commons-lang

    [ https://issues.apache.org/jira/browse/PARQUET-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088534#comment-17088534 ] 

ASF GitHub Bot commented on PARQUET-1844:
-----------------------------------------

gszadovszky opened a new pull request #787:
URL: https://github.com/apache/parquet-mr/pull/787


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Removed Hadoop transitive dependency on commons-lang
> ----------------------------------------------------
>
>                 Key: PARQUET-1844
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1844
>             Project: Parquet
>          Issue Type: Task
>            Reporter: Gabor Szadovszky
>            Priority: Major
>
> Some of our code parts are using commons-lang without declaring direct dependency on it. It comes as a transitive dependency from Hadoop. From Hadoop 3.3 they migrated from commons-lang to commons-lang3 which fails the build if parquet-mr is built against it.
> We shall either properly declare our direct dependency to commons-lang (or with also migrating to commons-lang3) or refactor the code to not use commons-lang at all.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)