You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by makeyang <gi...@git.apache.org> on 2018/06/01 11:50:46 UTC
[GitHub] flink pull request #6110: [hotfix] fix EXECUTION_FAILOVER_STRATEGY's comment...
GitHub user makeyang opened a pull request:
https://github.com/apache/flink/pull/6110
[hotfix] fix EXECUTION_FAILOVER_STRATEGY's comments error and its inf…
## What is the purpose of the change
fix EXECUTION_FAILOVER_STRATEGY's comments error and its info message error
## Brief change log
modified comments and info message
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/makeyang/flink hotfix-comment-failover
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6110.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6110
----
commit 6a5854363df5ced564c025f9ae1ad53da9dc950c
Author: makeyang <ma...@...>
Date: 2018-06-01T11:47:15Z
[hotfix] fix EXECUTION_FAILOVER_STRATEGY's comments error and its info message error
----
---
[GitHub] flink issue #6110: [hotfix] fix EXECUTION_FAILOVER_STRATEGY's comments error...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6110
Thanks @makeyang for your contribution.
Could you also regenerate the documentation to update the description for this option on the web page.
You can do it by:
mvn package -Dgenerate-config-docs -pl flink-docs -am -nsu
---
[GitHub] flink issue #6110: [hotfix] fix EXECUTION_FAILOVER_STRATEGY's comments error...
Posted by makeyang <gi...@git.apache.org>.
Github user makeyang commented on the issue:
https://github.com/apache/flink/pull/6110
can anybody take a look at it? it's pretty straightforward
---