[jira] [Comment Edited] (HBASE-20257) hbase-spark should not depend on com.google.code.findbugs.jsr305

["Sean Busbey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413878#comment-16413878 ] 

Sean Busbey edited comment on HBASE-20257 at 3/26/18 1:55 PM:
--------------------------------------------------------------

Please remove this execution entirely rather than switching the fail state (we'll get that when we inherit the execution)

{code}
@@ -534,14 +523,13 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-enforcer-plugin</artifactId>
         <executions>
-          <!-- purposefully have jsr 305 exclusion only warn in this module -->
           <execution>
             <id>banned-jsr305</id>
             <goals>
               <goal>enforce</goal>
             </goals>
             <configuration>
-              <fail>false</fail>
+              <fail>true</fail>
             </configuration>
           </execution>
{code}


was (Author: busbey):
Please remove this execution entirely rather than switching the fail state (we'll get that when we inherit the execution)

{code}
538	          <execution>	526	          <execution>
539	            <id>banned-jsr305</id>	527	            <id>banned-jsr305</id>
540	            <goals>	528	            <goals>
541	              <goal>enforce</goal>	529	              <goal>enforce</goal>
542	            </goals>	530	            </goals>
543	            <configuration>	531	            <configuration>
544	              <fail>false</fail>	532	              <fail>true</fail>
545	            </configuration>	533	            </configuration>
546	          </execution>	534	          </execution>
{code}

> hbase-spark should not depend on com.google.code.findbugs.jsr305
> ----------------------------------------------------------------
>
>                 Key: HBASE-20257
>                 URL: https://issues.apache.org/jira/browse/HBASE-20257
>             Project: HBase
>          Issue Type: Task
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Ted Yu
>            Assignee: Artem Ervits
>            Priority: Minor
>              Labels: beginner
>         Attachments: HBASE-20257.v01.patch, HBASE-20257.v02.patch
>
>
> The following can be observed in the build output of master branch:
> {code}
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with message:
> We don't allow the JSR305 jar from the Findbugs project, see HBASE-16321.
> Found Banned Dependency: com.google.code.findbugs:jsr305:jar:1.3.9
> Use 'mvn dependency:tree' to locate the source of the banned dependencies.
> {code}
> Here is related snippet from hbase-spark/pom.xml:
> {code}
>     <dependency>
>       <groupId>com.google.code.findbugs</groupId>
>       <artifactId>jsr305</artifactId>
> {code}
> Dependency on jsr305 should be dropped.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)