You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2026/09/15 11:31:02 UTC
[PR] [FLINK-40671][network] Document why UnknownInputChannel graduation hardcodes needsRecovery=false [flink]
1996fanrui opened a new pull request, #29191:
URL: https://github.com/apache/flink/pull/29191
## What is the purpose of the change
`UnknownInputChannel.toRemoteInputChannel` / `toLocalInputChannel` hardcode
`needsRecovery=false` when graduating to a real channel. This looks unsafe next to the
recovery path, but it is correct: unknown channels only exist in BATCH jobs, which have no
channel state, while channel-state recovery only exists in streaming (unaligned checkpoints) —
the two are mutually exclusive. This adds a comment documenting that invariant.
## Brief change log
- Comment-only, at the two graduation sites in `UnknownInputChannel`.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40671][network] Document why UnknownInputChannel graduation hardcodes needsRecovery=false [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on code in PR #29191:
URL: https://github.com/apache/flink/pull/29191#discussion_r4036286844
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnknownInputChannel.java:
##########
@@ -192,6 +192,8 @@ public RemoteInputChannel toRemoteInputChannel(
metrics.getNumBytesInRemoteCounter(),
metrics.getNumBuffersInRemoteCounter(),
channelStateWriter == null ? ChannelStateWriter.NO_OP : channelStateWriter,
+ // Unknown channels exist only in BATCH jobs, which have no channel
Review Comment:
Hey @davidradl , I received some code review offline, and it mentioned that `needsRecovery is always false` in `UnknownInputChannel` is a risk that potentially missing the recovery path.
After analysis, the `Unknown channels exist only in BATCH jobs`, so this risk does not actually apply.
I’m inclined to add some documentation comments here to clarify this, ensuring that AI or developers can correctly understand the situation quickly, and avoid confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40671][network] Document why UnknownInputChannel graduation hardcodes needsRecovery=false [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #29191:
URL: https://github.com/apache/flink/pull/29191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40671][network] Document why UnknownInputChannel graduation hardcodes needsRecovery=false [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #29191:
URL: https://github.com/apache/flink/pull/29191#issuecomment-5679548118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "80ddbbbc8fef76add137df523a17bfa92e501209",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "80ddbbbc8fef76add137df523a17bfa92e501209",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 80ddbbbc8fef76add137df523a17bfa92e501209 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40671][network] Document why UnknownInputChannel graduation hardcodes needsRecovery=false [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #29191:
URL: https://github.com/apache/flink/pull/29191#discussion_r4015434333
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnknownInputChannel.java:
##########
@@ -192,6 +192,8 @@ public RemoteInputChannel toRemoteInputChannel(
metrics.getNumBytesInRemoteCounter(),
metrics.getNumBuffersInRemoteCounter(),
channelStateWriter == null ? ChannelStateWriter.NO_OP : channelStateWriter,
+ // Unknown channels exist only in BATCH jobs, which have no channel
Review Comment:
I was expecting a change to the docs from the PR title. Is there an external consideration that we could add to the docs around this? Or is this just for code hygene?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org