[GitHub] Ovilia commented on a change in pull request #8759: Enhance pie chart label display policy

[GitBox <gi...@apache.org>]

Ovilia commented on a change in pull request #8759: Enhance pie chart label display policy
URL: https://github.com/apache/incubator-echarts/pull/8759#discussion_r214621892
 
 

 ##########
 File path: src/chart/funnel/funnelLayout.js
 ##########
 @@ -71,9 +71,19 @@ function labelLayout(data) {
         var linePoints;
 
         if (isLabelInside) {
-            textX = (points[0][0] + points[1][0] + points[2][0] + points[3][0]) / 4;
-            textY = (points[0][1] + points[1][1] + points[2][1] + points[3][1]) / 4;
-            textAlign = 'center';
+            if (labelPosition === 'insideLeft'){
 
 Review comment:
   Add space: `if (labelPosition === 'insideLeft') {`.
   Also change the similar problems.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org