You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by re...@apache.org on 2024/03/05 16:05:32 UTC
(jackrabbit-oak) branch 1.22 updated: OAK-10524: SameNameSiblingTest: add (failing) test for getName() semantics
This is an automated email from the ASF dual-hosted git repository.
reschke pushed a commit to branch 1.22
in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git
The following commit(s) were added to refs/heads/1.22 by this push:
new 92e4882863 OAK-10524: SameNameSiblingTest: add (failing) test for getName() semantics
92e4882863 is described below
commit 92e4882863ef268fbbf5a98e31ad45af4a94ed69
Author: Julian Reschke <re...@apache.org>
AuthorDate: Fri Oct 27 14:03:53 2023 +0100
OAK-10524: SameNameSiblingTest: add (failing) test for getName() semantics
---
.../org/apache/jackrabbit/oak/jcr/SameNameSiblingTest.java | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/SameNameSiblingTest.java b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/SameNameSiblingTest.java
index feab9d4cf3..6836b21d9f 100644
--- a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/SameNameSiblingTest.java
+++ b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/SameNameSiblingTest.java
@@ -43,6 +43,7 @@ import org.apache.jackrabbit.oak.spi.commit.EmptyHook;
import org.apache.jackrabbit.oak.spi.state.NodeBuilder;
import org.apache.jackrabbit.oak.spi.state.NodeStore;
import org.junit.Before;
+import org.junit.Ignore;
import org.junit.Test;
public class SameNameSiblingTest extends AbstractRepositoryTest {
@@ -108,6 +109,18 @@ public class SameNameSiblingTest extends AbstractRepositoryTest {
}
}
+ @Test
+ @Ignore("OAK-10523")
+ public void getSiblingNames() throws RepositoryException {
+ for (String name : SIBLINGS) {
+ Node sib = sns.getNode(name);
+ String n = sib.getName();
+ int i = sib.getIndex();
+ assertTrue("Node.getName() must return valid JCR name (index stripped), but got: " + n, !n.contains("["));
+ assertEquals(name, n + "[" + i + "]");
+ }
+ }
+
@Test
public void modifySiblings() throws RepositoryException {
for (String name : SIBLINGS) {