You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@click.apache.org by sa...@apache.org on 2009/01/19 21:28:06 UTC

svn commit: r735793 - in /incubator/click/trunk/click: extras/src/org/apache/click/extras/control/ extras/src/org/apache/click/extras/tree/ framework/src/org/apache/click/control/

Author: sabob
Date: Mon Jan 19 12:28:06 2009
New Revision: 735793

URL: http://svn.apache.org/viewvc?rev=735793&view=rev
Log:
encode ampersand in url. CLK-483

Modified:
    incubator/click/trunk/click/extras/src/org/apache/click/extras/control/AutoCompleteTextField.java
    incubator/click/trunk/click/extras/src/org/apache/click/extras/control/ExternalLink.java
    incubator/click/trunk/click/extras/src/org/apache/click/extras/tree/Tree.java
    incubator/click/trunk/click/framework/src/org/apache/click/control/ActionButton.java
    incubator/click/trunk/click/framework/src/org/apache/click/control/ActionLink.java
    incubator/click/trunk/click/framework/src/org/apache/click/control/PageLink.java

Modified: incubator/click/trunk/click/extras/src/org/apache/click/extras/control/AutoCompleteTextField.java
URL: http://svn.apache.org/viewvc/incubator/click/trunk/click/extras/src/org/apache/click/extras/control/AutoCompleteTextField.java?rev=735793&r1=735792&r2=735793&view=diff
==============================================================================
--- incubator/click/trunk/click/extras/src/org/apache/click/extras/control/AutoCompleteTextField.java (original)
+++ incubator/click/trunk/click/extras/src/org/apache/click/extras/control/AutoCompleteTextField.java Mon Jan 19 12:28:06 2009
@@ -198,12 +198,12 @@
      * <pre class="prettyprint">
      * public void onInit() {
      *     AutoCompleteTextField cityField = new AutoCompleteTextField("cityField");
-        *     HtmlStringBuffer buffer = new HtmlStringBuffer();
+     *     HtmlStringBuffer buffer = new HtmlStringBuffer();
      *     buffer.append("{"); // Options opens with squiggly bracket
-           *     buffer.append(stateField.getName());
-           *     buffer.append("=");
-           *     buffer.append(stateField.getValue());
-           *     buffer.append("&");
+     *     buffer.append(stateField.getName());
+     *     buffer.append("=");
+     *     buffer.append(stateField.getValue());
+     *     buffer.append("&amp;");
      *     buffer.append(idField.getName());
      *     buffer.append("=");
      *     buffer.append(idField.getValue());

Modified: incubator/click/trunk/click/extras/src/org/apache/click/extras/control/ExternalLink.java
URL: http://svn.apache.org/viewvc/incubator/click/trunk/click/extras/src/org/apache/click/extras/control/ExternalLink.java?rev=735793&r1=735792&r2=735793&view=diff
==============================================================================
--- incubator/click/trunk/click/extras/src/org/apache/click/extras/control/ExternalLink.java (original)
+++ incubator/click/trunk/click/extras/src/org/apache/click/extras/control/ExternalLink.java Mon Jan 19 12:28:06 2009
@@ -119,7 +119,7 @@
                 buffer.append("=");
                 buffer.append(ClickUtils.encodeUrl(value, getContext()));
                 if (i.hasNext()) {
-                    buffer.append("&");
+                    buffer.append("&amp;");
                 }
             }
         }

Modified: incubator/click/trunk/click/extras/src/org/apache/click/extras/tree/Tree.java
URL: http://svn.apache.org/viewvc/incubator/click/trunk/click/extras/src/org/apache/click/extras/tree/Tree.java?rev=735793&r1=735792&r2=735793&view=diff
==============================================================================
--- incubator/click/trunk/click/extras/src/org/apache/click/extras/tree/Tree.java (original)
+++ incubator/click/trunk/click/extras/src/org/apache/click/extras/tree/Tree.java Mon Jan 19 12:28:06 2009
@@ -1528,7 +1528,7 @@
                 buffer.append("=");
                 buffer.append(ClickUtils.encodeUrl(value, context));
                 if (i.hasNext()) {
-                    buffer.append("&");
+                    buffer.append("&amp;");
                 }
             }
         }

Modified: incubator/click/trunk/click/framework/src/org/apache/click/control/ActionButton.java
URL: http://svn.apache.org/viewvc/incubator/click/trunk/click/framework/src/org/apache/click/control/ActionButton.java?rev=735793&r1=735792&r2=735793&view=diff
==============================================================================
--- incubator/click/trunk/click/framework/src/org/apache/click/control/ActionButton.java (original)
+++ incubator/click/trunk/click/framework/src/org/apache/click/control/ActionButton.java Mon Jan 19 12:28:06 2009
@@ -267,7 +267,7 @@
         buffer.append(getName());
 
         if (value != null) {
-            buffer.append("&");
+            buffer.append("&amp;");
             buffer.append(VALUE);
             buffer.append("=");
             buffer.append(ClickUtils.encodeUrl(value, context));
@@ -281,7 +281,7 @@
                     Object paramValue = getParameters().get(name);
                     String encodedValue
                         = ClickUtils.encodeUrl(paramValue, context);
-                    buffer.append("&");
+                    buffer.append("&amp;");
                     buffer.append(name);
                     buffer.append("=");
                     buffer.append(encodedValue);

Modified: incubator/click/trunk/click/framework/src/org/apache/click/control/ActionLink.java
URL: http://svn.apache.org/viewvc/incubator/click/trunk/click/framework/src/org/apache/click/control/ActionLink.java?rev=735793&r1=735792&r2=735793&view=diff
==============================================================================
--- incubator/click/trunk/click/framework/src/org/apache/click/control/ActionLink.java (original)
+++ incubator/click/trunk/click/framework/src/org/apache/click/control/ActionLink.java Mon Jan 19 12:28:06 2009
@@ -305,7 +305,7 @@
         buffer.append("=");
         buffer.append(getName());
         if (value != null) {
-            buffer.append("&");
+            buffer.append("&amp;");
             buffer.append(VALUE);
             buffer.append("=");
             buffer.append(ClickUtils.encodeUrl(value, context));
@@ -319,7 +319,7 @@
                     Object paramValue = getParameters().get(name);
                     String encodedValue =
                         ClickUtils.encodeUrl(paramValue, context);
-                    buffer.append("&");
+                    buffer.append("&amp;");
                     buffer.append(name);
                     buffer.append("=");
                     buffer.append(encodedValue);

Modified: incubator/click/trunk/click/framework/src/org/apache/click/control/PageLink.java
URL: http://svn.apache.org/viewvc/incubator/click/trunk/click/framework/src/org/apache/click/control/PageLink.java?rev=735793&r1=735792&r2=735793&view=diff
==============================================================================
--- incubator/click/trunk/click/framework/src/org/apache/click/control/PageLink.java (original)
+++ incubator/click/trunk/click/framework/src/org/apache/click/control/PageLink.java Mon Jan 19 12:28:06 2009
@@ -163,7 +163,7 @@
                 buffer.append("=");
                 buffer.append(ClickUtils.encodeUrl(value, context));
                 if (i.hasNext()) {
-                    buffer.append("&");
+                    buffer.append("&amp;");
                 }
             }
         }