[GitHub] [rocketmq] duhenglucky commented on a change in pull request #1703: [ISSUE #1588] Fix Issue 1588 retry doesn't work when sending msg in async mode and the broker is down

[GitBox <gi...@apache.org>]

duhenglucky commented on a change in pull request #1703: [ISSUE #1588] Fix Issue 1588 retry doesn't work when sending msg in async mode and the broker is down
URL: https://github.com/apache/rocketmq/pull/1703#discussion_r378057917
 
 

 ##########
 File path: client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
 ##########
 @@ -559,7 +559,7 @@ private SendResult sendDefaultImpl(
             MessageQueue mq = null;
             Exception exception = null;
             SendResult sendResult = null;
-            int timesTotal = communicationMode == CommunicationMode.SYNC ? 1 + this.defaultMQProducer.getRetryTimesWhenSendFailed() : 1;
 
 Review comment:
   (1) Async Retry used another parameter for retry when send failed: retryTimesWhenSendAsyncFailed
   (2) CommunicationMode has there value: SYNC, ASYNC, ONEWAY, and send the message will return directly when using the last two values. so this modification seems has no effect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services