You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Amar3tto (via GitHub)" <gi...@apache.org> on 2025/10/09 05:28:44 UTC
[PR] Fix vLLM Gemma, add vLLM extra [beam]
Amar3tto opened a new pull request, #36451:
URL: https://github.com/apache/beam/pull/36451
Fixes #30644
Successful run: https://github.com/apache/beam/actions/runs/18355344484/job/52285825077
This PR also contains changes from https://github.com/apache/beam/pull/36420
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix vLLM Gemma, add vLLM extra [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36451:
URL: https://github.com/apache/beam/pull/36451#issuecomment-3442669612
Assigning reviewers:
R: @claudevdm for label python.
R: @Abacn for label build.
R: @damccorm for label website.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix vLLM Gemma, add vLLM extra [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36451:
URL: https://github.com/apache/beam/pull/36451#issuecomment-3384425951
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix vLLM Gemma, add vLLM extra [beam]
Posted by "Amar3tto (via GitHub)" <gi...@apache.org>.
Amar3tto commented on PR #36451:
URL: https://github.com/apache/beam/pull/36451#issuecomment-3444233041
@damccorm fixed comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix vLLM Gemma, add vLLM extra [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #36451:
URL: https://github.com/apache/beam/pull/36451#issuecomment-3384189889
## Summary of Changes
Hello @Amar3tto, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request by Amar3tto addresses a vLLM Gemma issue (#30644) and introduces a `vllm` extra to the Apache Beam Python SDK. Key changes include defining the `vllm` extra and its dependencies in `setup.py`, updating the `vllm.dockerfile` to leverage this extra, adding `dill` to test requirements, and modifying build scripts (`common.gradle`, `run_generate_requirements.sh`) to properly handle `vllm` dependencies, including a conditional `torch` installation to prevent known issues. The PR also integrates changes from #36420.
### Highlights
* **Intent**: This pull request aims to fix an issue related to vLLM Gemma (addressing #30644) and introduce a new `vllm` extra for the Apache Beam Python SDK. It also incorporates changes from a related pull request (#36420).
* **Changes Overview**: The changes primarily focus on integrating vLLM support more robustly into the Beam Python SDK. This includes defining a new `vllm` extra in `setup.py` with its specific dependencies (`openai`, `vllm`, `triton`). The `vllm.dockerfile` for test resources is updated to use this new extra, simplifying dependency installation. Additionally, `dill` is added to `vllm_tests_requirements.txt`, and the `common.gradle` script is modified to generate `gpu_image_requirements.txt` that includes the `vllm` extra. A conditional `torch` installation is added to `run_generate_requirements.sh` to mitigate a known issue when `vllm` extra is used.
* **Reviewer Activity**: No specific reviewer activity has been noted yet for this pull request.
<details>
<summary><b>Ignored Files</b></summary>
* **Ignored by pattern:** `.github/workflows/**` (1)
* .github/workflows/load-tests-pipeline-options/beam_Inference_Python_Benchmarks_Dataflow_VLLM_Gemma_Batch.txt
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix vLLM Gemma, add vLLM extra [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #36451:
URL: https://github.com/apache/beam/pull/36451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix vLLM Gemma, add vLLM extra [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #36451:
URL: https://github.com/apache/beam/pull/36451#discussion_r2460594163
##########
sdks/python/container/common.gradle:
##########
@@ -53,7 +53,19 @@ def generatePythonRequirements = tasks.register("generatePythonRequirements") {
"${files(configurations.sdkSourceTarball.files).singleFile} " +
"ml_image_requirements.txt " +
"container/ml " +
- "[gcp,dataframe,test,ml_cpu] " +
+ "[gcp,dataframe,test,tensorflow,torch,transformers] " +
+ "${pipExtraOptions}"
+ }
+ // GPU requirements not used for any containers directly due to licensing,
+ // but can be picked up by customers or other consumers for use.
+ exec {
+ executable 'sh'
+ args '-c', "cd ${rootDir} && ${runScriptsPath} " +
+ "${project.ext.pythonVersion} " +
+ "${files(configurations.sdkSourceTarball.files).singleFile} " +
+ "gpu_image_requirements.txt " +
+ "container/ml " +
+ "[gcp,dataframe,test,tensorflow,torch,transformers,vllm] " +
"${pipExtraOptions}"
}
Review Comment:
Lets revert the pieces inside sdks/python/container for now (this and run_generate_requirements.sh) - they aren't working yet in a CI environment
##########
.github/workflows/refresh_looker_metrics.yml:
##########
@@ -19,26 +19,20 @@ name: Refresh Looker Performance Metrics
on:
workflow_dispatch:
- inputs:
- READ_ONLY:
- description: 'Run in read-only mode'
- required: false
- default: 'true'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LOOKERSDK_BASE_URL: ${{ secrets.LOOKERSDK_BASE_URL }}
LOOKERSDK_CLIENT_ID: ${{ secrets.LOOKERSDK_CLIENT_ID }}
LOOKERSDK_CLIENT_SECRET: ${{ secrets.LOOKERSDK_CLIENT_SECRET }}
GCS_BUCKET: 'public_looker_explores_us_a3853f40'
- READ_ONLY: ${{ inputs.READ_ONLY }}
Review Comment:
Is this related to the vllm pieces? Rather than removing it entirely, we could also just flip the default to false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix vLLM Gemma, add vLLM extra [beam]
Posted by "Amar3tto (via GitHub)" <gi...@apache.org>.
Amar3tto commented on code in PR #36451:
URL: https://github.com/apache/beam/pull/36451#discussion_r2460963224
##########
.github/workflows/refresh_looker_metrics.yml:
##########
@@ -19,26 +19,20 @@ name: Refresh Looker Performance Metrics
on:
workflow_dispatch:
- inputs:
- READ_ONLY:
- description: 'Run in read-only mode'
- required: false
- default: 'true'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LOOKERSDK_BASE_URL: ${{ secrets.LOOKERSDK_BASE_URL }}
LOOKERSDK_CLIENT_ID: ${{ secrets.LOOKERSDK_CLIENT_ID }}
LOOKERSDK_CLIENT_SECRET: ${{ secrets.LOOKERSDK_CLIENT_SECRET }}
GCS_BUCKET: 'public_looker_explores_us_a3853f40'
- READ_ONLY: ${{ inputs.READ_ONLY }}
Review Comment:
I found that this parameter was added by mistake and never used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix vLLM Gemma, add vLLM extra [beam]
Posted by "Amar3tto (via GitHub)" <gi...@apache.org>.
Amar3tto commented on code in PR #36451:
URL: https://github.com/apache/beam/pull/36451#discussion_r2460979356
##########
sdks/python/container/common.gradle:
##########
@@ -53,7 +53,19 @@ def generatePythonRequirements = tasks.register("generatePythonRequirements") {
"${files(configurations.sdkSourceTarball.files).singleFile} " +
"ml_image_requirements.txt " +
"container/ml " +
- "[gcp,dataframe,test,ml_cpu] " +
+ "[gcp,dataframe,test,tensorflow,torch,transformers] " +
+ "${pipExtraOptions}"
+ }
+ // GPU requirements not used for any containers directly due to licensing,
+ // but can be picked up by customers or other consumers for use.
+ exec {
+ executable 'sh'
+ args '-c', "cd ${rootDir} && ${runScriptsPath} " +
+ "${project.ext.pythonVersion} " +
+ "${files(configurations.sdkSourceTarball.files).singleFile} " +
+ "gpu_image_requirements.txt " +
+ "container/ml " +
+ "[gcp,dataframe,test,tensorflow,torch,transformers,vllm] " +
"${pipExtraOptions}"
}
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix vLLM Gemma, add vLLM extra [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #36451:
URL: https://github.com/apache/beam/pull/36451#issuecomment-3384213903
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/36451?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 36.22%. Comparing base ([`c52cb21`](https://app.codecov.io/gh/apache/beam/commit/c52cb21ba05856b072a2e3d4c9bc56cd6fbc1d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`182219c`](https://app.codecov.io/gh/apache/beam/commit/182219c5b60645cda221317b428da3bc842ebe46?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 30 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #36451 +/- ##
=============================================
- Coverage 55.04% 36.22% -18.83%
Complexity 1667 1667
=============================================
Files 1058 1058
Lines 165211 165236 +25
Branches 1190 1190
=============================================
- Hits 90939 59852 -31087
- Misses 72096 103208 +31112
Partials 2176 2176
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/36451/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/36451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.53% <ø> (-40.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/36451?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org