[GitHub] [superset] michael-s-molina commented on a change in pull request #14687: fix(explore): Don't run data panel query when control panel has errors

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #14687:
URL: https://github.com/apache/superset/pull/14687#discussion_r637405232



##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -262,6 +282,9 @@ export const DataTablesPane = ({
         />
       );
     }
+    if (errorMessage) {
+      return <pre>{errorMessage}</pre>;

Review comment:
       @kgabryje Can you replace, in this PR or in a follow up, both instances of `<pre>` with the `Alert` component just like the chart container?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org