[GitHub] [zookeeper] XavierChengZW commented on pull request #1337: ZOOKEEPER-3811 : cleaning up code,static field be directly referred by its class name

[GitBox <gi...@apache.org>]

XavierChengZW commented on pull request #1337:
URL: https://github.com/apache/zookeeper/pull/1337#issuecomment-620544973


   > Looks good.
   > Can you please open a JIRA and cite the jira ticket id on the commit message? Then we are good to commit this patch.
   > 
   > Personally I don't think this is really an 'optimized' version of the code but now the code looks cleaner. We should check the actual byte code emitted by javac
   > 
   > It is strange that spotbugs did not quarrel about these accesses to static variables.
   > Did we put some FBSuppressWarning directive?
   
   Yeah 
   
   > Looks good.
   > Can you please open a JIRA and cite the jira ticket id on the commit message? Then we are good to commit this patch.
   > 
   > Personally I don't think this is really an 'optimized' version of the code but now the code looks cleaner. We should check the actual byte code emitted by javac
   > 
   > It is strange that spotbugs did not quarrel about these accesses to static variables.
   > Did we put some FBSuppressWarning directive?
   
   OK, I've added a JIRA and changed the title description.  When you are in spotbugs, you can use a variety of code specification plug-ins to scan, which will have a good effect


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org