[jira] Commented: (MAHOUT-127) Remove warnings

["Benson Margulies (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAHOUT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714935#action_12714935 ] 

Benson Margulies commented on MAHOUT-127:
-----------------------------------------

This is a hadoop prank and I'm not sure what to do about it.

The 'right' thing to put in DummyOutputCollector is 

public class DummyOutputCollector<K extends WritableComparable<BinaryComparable>, V extends Writable> implements OutputCollector<K, V> {

That doesn't work, however, because of the use of LongWritable in EvalMapperTest. LongWritable inherits the WritableComparable interface without any parameters. So I think an @SuppressWarnings is called for in DummyOutputCollector until/unless Hadoop gets better, unless someone wants to find a way around using LongWritable.


> Remove warnings 
> ----------------
>
>                 Key: MAHOUT-127
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-127
>             Project: Mahout
>          Issue Type: Improvement
>    Affects Versions: 0.2
>            Reporter: Benson Margulies
>            Assignee: Sean Owen
>            Priority: Minor
>             Fix For: 0.2
>
>         Attachments: warnings.diff, warnings.patch
>
>
> The patch I'm about to attach gets rid of all the current yellow triangles for Eclipse 3.4.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.