You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2024/04/23 12:05:02 UTC
[PR] Using apache kudu docker images and update kudu-client version [pekko-connectors]
laglangyue opened a new pull request, #626:
URL: https://github.com/apache/pekko-connectors/pull/626
## movtication
we use the kudu images but not from apacheļ¼so update it, and update the version
Although I am not an expert in kudu, I am capable of solving this problem. I did some digging and found that the new version of kudu will try TLS connection, so the connection failed
## test
test it locally ok
## future
I add `encryptionPolicy(EncryptionPolicy.OPTIONAL)` to client temporaryly.
It need to some improvment for client.
In my opinion, we should provide a way for users to pass us a client that can be customized by the user
```java
public enum EncryptionPolicy {
// Optional, it uses encrypted connection if the server supports it
// but it can connect to insecure servers too.
OPTIONAL,
// Only connects to remote servers that support encryption, fails
// otherwise. It can connect to insecure servers only locally.
REQUIRED_REMOTE,
// Only connects to any server, including on the loopback interface,
// that support encryption, fails otherwise.
REQUIRED,
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Using apache kudu docker images and update kudu-client version [pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #626:
URL: https://github.com/apache/pekko-connectors/pull/626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Using apache kudu docker images and update kudu-client version [pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #626:
URL: https://github.com/apache/pekko-connectors/pull/626#issuecomment-2072209124
Thanks - I've restarted the CI runs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Using apache kudu docker images and update kudu-client version [pekko-connectors]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #626:
URL: https://github.com/apache/pekko-connectors/pull/626#issuecomment-2072129714
@pjfanning
I know you've made some efforts for Kudu before, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Using apache kudu docker images and update kudu-client version [pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #626:
URL: https://github.com/apache/pekko-connectors/pull/626#discussion_r1576166017
##########
kudu/src/main/scala/org/apache/pekko/stream/connectors/kudu/KuduClientExt.scala:
##########
@@ -13,8 +13,9 @@
package org.apache.pekko.stream.connectors.kudu
+import org.apache.kudu.client.AsyncKuduClient.EncryptionPolicy
import org.apache.pekko
-import pekko.actor.{ ClassicActorSystemProvider, ExtendedActorSystem, Extension, ExtensionId, ExtensionIdProvider }
+import pekko.actor.{ClassicActorSystemProvider, ExtendedActorSystem, Extension, ExtensionId, ExtensionIdProvider}
Review Comment:
please fix the scalafmt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Using apache kudu docker images and update kudu-client version [pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #626:
URL: https://github.com/apache/pekko-connectors/pull/626#discussion_r1576167819
##########
project/Dependencies.scala:
##########
@@ -420,7 +418,7 @@ object Dependencies {
"com.google.jimfs" % "jimfs" % "1.3.0" % Test,
"org.scalacheck" %% "scalacheck" % scalaCheckVersion % Test,
"org.scalatestplus" %% scalaTestScalaCheckArtifact % scalaTestScalaCheckVersion % Test) ++
- wireMockDependencies)
+ wireMockDependencies)
Review Comment:
please remove this format change - it will probably cause a scalafmt failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Using apache kudu docker images and update kudu-client version [pekko-connectors]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #626:
URL: https://github.com/apache/pekko-connectors/pull/626#issuecomment-2072192256
I check it again, I add a config for EncryptionPolicy. PTAL @pjfanning
In fact, implementation of kudu connector is too simple, and If I have time, I will submit a pr in futrue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Using apache kudu docker images and update kudu-client version [pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #626:
URL: https://github.com/apache/pekko-connectors/pull/626#discussion_r1576166447
##########
kudu/src/main/scala/org/apache/pekko/stream/connectors/kudu/KuduClientExt.scala:
##########
@@ -13,8 +13,9 @@
package org.apache.pekko.stream.connectors.kudu
+import org.apache.kudu.client.AsyncKuduClient.EncryptionPolicy
Review Comment:
please keep the kudu imports together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Using apache kudu docker images and update kudu-client version [pekko-connectors]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #626:
URL: https://github.com/apache/pekko-connectors/pull/626#issuecomment-2072147188
I check the log about container.
Then I found a issue about kudu TLS
https://issues.apache.org/jira/browse/KUDU-2647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Using apache kudu docker images and update kudu-client version [pekko-connectors]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #626:
URL: https://github.com/apache/pekko-connectors/pull/626#issuecomment-2072136782
reference to
https://github.com/apache/kudu/blob/master/docker/quickstart.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Using apache kudu docker images and update kudu-client version [pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #626:
URL: https://github.com/apache/pekko-connectors/pull/626#issuecomment-2072256313
Thanks @laglangyue - merged. I have labelled this as needing a mention in the release notes due to the new config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org