[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

[GitBox <gi...@apache.org>]

tristaZero commented on a change in pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r622996004



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/database/type/dialect/SQLServerDatabaseType.java
##########
@@ -41,7 +41,7 @@ public QuoteCharacter getQuoteCharacter() {
     
     @Override
     public Collection<String> getJdbcUrlPrefixes() {
-        return Collections.singletonList("jdbc:microsoft:sqlserver:");
+        return Collections.singletonList("jdbc:sqlserver:");

Review comment:
       Hi @cilfm ,
   Glad to see your PR here.
   If your modification is an option for sqlserver's jdbc, I mean the pevious jdbc is still correct in some case, we can consider `microsoft?`. 
   Plus, it is required to add a test in its unit test class.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org