You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/14 20:17:10 UTC
[GitHub] [spark] HeartSaVioR commented on a change in pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax
HeartSaVioR commented on a change in pull request #28517:
URL: https://github.com/apache/spark/pull/28517#discussion_r425404763
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -2195,22 +2195,4 @@ class DDLParserSuite extends AnalysisTest {
parsePlan("COMMENT ON TABLE a.b.c IS 'xYz'"),
CommentOnTable(UnresolvedTable(Seq("a", "b", "c")), "xYz"))
}
-
- test("create table - without using") {
Review comment:
It's straightforward for removed tests - I'll do that.
What about the tests being reverted as Hive create table is not integrated with DSv2?
(I'm referring `sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala`)
I guess they still need to be reverted instead of ignore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org