You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2023/10/19 11:24:35 UTC
[tomcat] branch main updated: Add charset
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new c22b15fae5 Add charset
c22b15fae5 is described below
commit c22b15fae5a7b510fb624013f2008f7bbfafa986
Author: remm <re...@apache.org>
AuthorDate: Thu Oct 19 13:24:14 2023 +0200
Add charset
---
java/org/apache/catalina/manager/StatusTransformer.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/catalina/manager/StatusTransformer.java b/java/org/apache/catalina/manager/StatusTransformer.java
index e4fbf52ca7..3aa7f3e922 100644
--- a/java/org/apache/catalina/manager/StatusTransformer.java
+++ b/java/org/apache/catalina/manager/StatusTransformer.java
@@ -53,7 +53,7 @@ public class StatusTransformer {
} else if (mode == 1) {
response.setContentType("text/xml;charset=" + Constants.CHARSET);
} else if (mode == 2) {
- response.setContentType("application/json");
+ response.setContentType("application/json;charset=" + Constants.CHARSET);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch main updated: Add charset
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Michael,
On 10/19/23 08:30, Michael Osipov wrote:
> On 2023/10/19 11:24:35 remm@apache.org wrote:
>> java/org/apache/catalina/manager/StatusTransformer.java | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/java/org/apache/catalina/manager/StatusTransformer.java b/java/org/apache/catalina/manager/StatusTransformer.java
>> index e4fbf52ca7..3aa7f3e922 100644
>> --- a/java/org/apache/catalina/manager/StatusTransformer.java
>> +++ b/java/org/apache/catalina/manager/StatusTransformer.java
>> @@ -53,7 +53,7 @@ public class StatusTransformer {
>> } else if (mode == 1) {
>> response.setContentType("text/xml;charset=" + Constants.CHARSET);
>> } else if (mode == 2) {
>> - response.setContentType("application/json");
>> + response.setContentType("application/json;charset=" + Constants.CHARSET);
>
> This is not much better. There is no charset parameter for JSON: https://www.iana.org/assignments/media-types/application/json
While you are technically right (charset is only a valid parameter for
text/* MIME types), this does not hurt and in fact fixes a bunch of
stupid clients.
We could use text/json;charset=utf8 if we wanted to, and we'd be in good
company[1]... at least back in 2015 :)
-chris
[1] https://en.wikipedia.org/wiki/JSON#cite_ref-faraday-stack-pull-2_31-0
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch main updated: Add charset
Posted by Rémy Maucherat <re...@apache.org>.
On Thu, Oct 19, 2023 at 2:30 PM Michael Osipov <mi...@apache.org> wrote:
>
> On 2023/10/19 11:24:35 remm@apache.org wrote:
> > java/org/apache/catalina/manager/StatusTransformer.java | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/java/org/apache/catalina/manager/StatusTransformer.java b/java/org/apache/catalina/manager/StatusTransformer.java
> > index e4fbf52ca7..3aa7f3e922 100644
> > --- a/java/org/apache/catalina/manager/StatusTransformer.java
> > +++ b/java/org/apache/catalina/manager/StatusTransformer.java
> > @@ -53,7 +53,7 @@ public class StatusTransformer {
> > } else if (mode == 1) {
> > response.setContentType("text/xml;charset=" + Constants.CHARSET);
> > } else if (mode == 2) {
> > - response.setContentType("application/json");
> > + response.setContentType("application/json;charset=" + Constants.CHARSET);
>
> This is not much better. There is no charset parameter for JSON: https://www.iana.org/assignments/media-types/application/json
If I use response.setCharacterEncoding(Constants.CHARSET) instead,
then it will do the same thing ultimately.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch main updated: Add charset
Posted by Michael Osipov <mi...@apache.org>.
On 2023/10/19 11:24:35 remm@apache.org wrote:
> java/org/apache/catalina/manager/StatusTransformer.java | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/java/org/apache/catalina/manager/StatusTransformer.java b/java/org/apache/catalina/manager/StatusTransformer.java
> index e4fbf52ca7..3aa7f3e922 100644
> --- a/java/org/apache/catalina/manager/StatusTransformer.java
> +++ b/java/org/apache/catalina/manager/StatusTransformer.java
> @@ -53,7 +53,7 @@ public class StatusTransformer {
> } else if (mode == 1) {
> response.setContentType("text/xml;charset=" + Constants.CHARSET);
> } else if (mode == 2) {
> - response.setContentType("application/json");
> + response.setContentType("application/json;charset=" + Constants.CHARSET);
This is not much better. There is no charset parameter for JSON: https://www.iana.org/assignments/media-types/application/json
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org