[GitHub] [spark] cloud-fan commented on a change in pull request #35255: [SPARK-37967][SQL] Literal.create support ObjectType

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35255:
URL: https://github.com/apache/spark/pull/35255#discussion_r788562985



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -158,6 +158,7 @@ object Literal {
         Literal(CatalystTypeConverters.createToCatalystConverter(dataType)(v), dataType)
       case _: DayTimeIntervalType if v.isInstanceOf[Duration] =>
         Literal(CatalystTypeConverters.createToCatalystConverter(dataType)(v), dataType)
+      case _: ObjectType => Literal(v, dataType)

Review comment:
       shall we do some assertion here? e.g. `v.getClass` should be or a sub-class of `ObjectType.cls`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org