You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/30 05:51:30 UTC

[GitHub] [incubator-nuttx-apps] tunefs opened a new pull request #790: netutils/ftpc: ftpc_getfile: Fixed permission check and resume offset.

tunefs opened a new pull request #790:
URL: https://github.com/apache/incubator-nuttx-apps/pull/790


   ## Summary
   A permission check is performed regardless of the result of stat(), and is used as a resume offset, which may result in invalid operation.
   
   ## Impact
   
   ## Testing
   I tested my local app on my custom board.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #790: netutils/ftpc: ftpc_getfile: Fixed permission check and resume offset.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #790:
URL: https://github.com/apache/incubator-nuttx-apps/pull/790#issuecomment-871117393


   @tunefs please fix this warning:
   apps/netutils/ftpc/ftpc_getfile.c:283:78: error: Long line found


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] tunefs commented on pull request #790: netutils/ftpc: ftpc_getfile: Fixed permission check and resume offset.

Posted by GitBox <gi...@apache.org>.
tunefs commented on pull request #790:
URL: https://github.com/apache/incubator-nuttx-apps/pull/790#issuecomment-871142986


   > Thanks for your patch. Could you sqaush the change into one patch with git rebase --interactive HEAD~2?
   
   I rebased and force pushed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] tunefs commented on pull request #790: netutils/ftpc: ftpc_getfile: Fixed permission check and resume offset.

Posted by GitBox <gi...@apache.org>.
tunefs commented on pull request #790:
URL: https://github.com/apache/incubator-nuttx-apps/pull/790#issuecomment-871124923


   I am sorry, I fixed long line warning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #790: netutils/ftpc: ftpc_getfile: Fixed permission check and resume offset.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #790:
URL: https://github.com/apache/incubator-nuttx-apps/pull/790


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #790: netutils/ftpc: ftpc_getfile: Fixed permission check and resume offset.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #790:
URL: https://github.com/apache/incubator-nuttx-apps/pull/790#issuecomment-871139955


   > I am sorry, I fixed long line warning.
   
   Thanks for your patch. Could you sqaush the change into one patch with git rebase --interactive HEAD~2?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org