You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "apurtell (via GitHub)" <gi...@apache.org> on 2026/05/01 22:31:14 UTC
[PR] PHOENIX-7817 Resolve Omid transaction manager via provider singleton view [phoenix]
apurtell opened a new pull request, #2435:
URL: https://github.com/apache/phoenix/pull/2435
`OmidTransactionClient` captures the provider's `HBaseTransactionManager` at construction time. `OmidTransactionContext` in turn caches that same reference in a private field. When a prior test class shuts down OMID's TSO together with its mini-cluster, the next test class reuses the stale wrapper and is dispatched to the dead executor. The symptom is a `RejectedExecutionException` originating from the OMID TSOClient state-machine executor.
In production the singleton's manager is set exactly once and never replaced, but the test framework exercises the swap path between classes within a single Surefire/Failsafe fork.
Fix:
`OmidTransactionClient` becomes a thin view onto the singleton's current `HBaseTransactionManager`. It resolves
`provider.transactionManager` on every call to `getTransactionClient()`. `transactionManager` is marked volatile so test-framework injection is published to other threads without synchronization.
In production the dynamic lookup is functionally identical to caching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7817 Resolve Omid transaction manager via provider singleton view [phoenix]
Posted by "palashc (via GitHub)" <gi...@apache.org>.
palashc commented on PR #2435:
URL: https://github.com/apache/phoenix/pull/2435#issuecomment-4846184119
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2435/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org