You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/18 22:09:00 UTC

[GitHub] [tvm] trevor-m opened a new pull request #7700: [TOPI][CUDA] Fix 0 valid boxes case for NMS when return_indices=False

trevor-m opened a new pull request #7700:
URL: https://github.com/apache/tvm/pull/7700


   When return_indices is False, the values of all boxes, scores must be set to -1 when they are invalid. The current code was not doing this, resulting in uninitialized memory being returned in the op output.
   
   Example output before fix, showing how output is incorrect for first inference and then is still incorrect but with different random output for second inference (due to unitialized memory being used). The input data is the same for all executions.
   ```
   mx top 10 score [-1. -1. -1. -1. -1. -1. -1. -1. -1. -1.]
   tvm top 10 score [0. 0. 0. ... 0. 0. 0.]
   tvm top 10 score [1.0032198 1.0016742 1.0015179 ... 1.0053984 1.0051595 1.0052176]
   ```
   
   With fix
   ```
   mx top 10 score [-1. -1. -1. -1. -1. -1. -1. -1. -1. -1.]
   tvm top 10 score [-1. -1. -1. ... -1. -1. -1.]
   tvm top 10 score [-1. -1. -1. ... -1. -1. -1.]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] trevor-m commented on pull request #7700: [TOPI][CUDA] Fix 0 valid boxes case for NMS when return_indices=False

Posted by GitBox <gi...@apache.org>.
trevor-m commented on pull request #7700:
URL: https://github.com/apache/tvm/pull/7700#issuecomment-802986993


   Thank @masahi @anijain2305 for the review! I have added a unit test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #7700: [TOPI][CUDA] Fix 0 valid boxes case for NMS when return_indices=False

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7700:
URL: https://github.com/apache/tvm/pull/7700#issuecomment-802651245


   Yes lets add a test @trevor-m 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #7700: [TOPI][CUDA] Fix 0 valid boxes case for NMS when return_indices=False

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7700:
URL: https://github.com/apache/tvm/pull/7700#issuecomment-803229118


   Thanks @trevor-m @anijain2305 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] trevor-m commented on pull request #7700: [TOPI][CUDA] Fix 0 valid boxes case for NMS when return_indices=False

Posted by GitBox <gi...@apache.org>.
trevor-m commented on pull request #7700:
URL: https://github.com/apache/tvm/pull/7700#issuecomment-802339326


   @anijain2305 @masahi Please take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #7700: [TOPI][CUDA] Fix 0 valid boxes case for NMS when return_indices=False

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7700:
URL: https://github.com/apache/tvm/pull/7700


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org