You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/07/21 15:50:07 UTC
Review Request 23736: Alerts: Updates to DAOs for Dispatch and History
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23736/
-----------------------------------------------------------
Review request for Ambari and Nate Cole.
Bugs: AMBARI-6547
https://issues.apache.org/jira/browse/AMBARI-6547
Repository: ambari
Description
-------
Adding more queries to DAOs and hooking up in-memory JPA tests for actually testing the ORM layer.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java 0fa803b
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java 9f36860
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java 65c2d0f
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 997fdfd
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 12b1fff
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java 2b01514
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java 8f84b49
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 32a2979
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntityPK.java 8fce36a
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 821cc3c
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java ca2d24e
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/23736/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:56.540s
[INFO] Finished at: Mon Jul 21 09:49:08 EDT 2014
[INFO] Final Memory: 22M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 23736: Alerts: Updates to DAOs for Dispatch and History
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23736/#review48221
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On July 21, 2014, 9:50 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23736/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 9:50 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-6547
> https://issues.apache.org/jira/browse/AMBARI-6547
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adding more queries to DAOs and hooking up in-memory JPA tests for actually testing the ORM layer.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java 0fa803b
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java 9f36860
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java 65c2d0f
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 997fdfd
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 12b1fff
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java 2b01514
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java 8f84b49
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 32a2979
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntityPK.java 8fce36a
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 821cc3c
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java ca2d24e
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23736/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:56.540s
> [INFO] Finished at: Mon Jul 21 09:49:08 EDT 2014
> [INFO] Final Memory: 22M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>