You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/05/14 08:38:37 UTC
[PR] CAMEL-23510: camel-jgroups - align Exchange header constant names with Camel naming convention [camel]
oscerd opened a new pull request, #23209:
URL: https://github.com/apache/camel/pull/23209
## Summary
Fixes [CAMEL-23510](https://issues.apache.org/jira/browse/CAMEL-23510).
The Exchange header constants in `JGroupsConstants` were using raw uppercase
string values (`JGROUPS_DEST`, `JGROUPS_SRC`, `JGROUPS_CHANNEL_ADDRESS`,
`JGROUPS_ORIGINAL_MESSAGE`) that do not follow the Camel naming convention
(`CamelXxxYyy`) used across the rest of the component catalog.
The Java field names are unchanged; only the header string values have
changed:
| Constant | Previous value | New value |
| --- | --- | --- |
| `JGroupsConstants.HEADER_JGROUPS_CHANNEL_ADDRESS` | `JGROUPS_CHANNEL_ADDRESS` | `CamelJGroupsChannelAddress` |
| `JGroupsConstants.HEADER_JGROUPS_DEST` | `JGROUPS_DEST` | `CamelJGroupsDest` |
| `JGroupsConstants.HEADER_JGROUPS_SRC` | `JGROUPS_SRC` | `CamelJGroupsSrc` |
| `JGroupsConstants.HEADER_JGROUPS_ORIGINAL_MESSAGE` | `JGROUPS_ORIGINAL_MESSAGE` | `CamelJGroupsOriginalMessage` |
Routes that reference the constants symbolically continue to work without
changes. Routes that set the header by its literal string value must be
updated to the new value (covered in the upgrade guide entry added in
this PR).
## Changes
- `components/camel-jgroups/src/main/java/org/apache/camel/component/jgroups/JGroupsConstants.java`: rename the four header string values to the `CamelJGroups*` convention.
- `docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_21.adoc`: add an upgrade-guide entry describing the rename.
- Regenerated metadata: `components/camel-jgroups/src/generated/resources/META-INF/.../jgroups.json`, `catalog/camel-catalog/src/generated/resources/.../jgroups.json`, `dsl/camel-endpointdsl/src/generated/java/.../JGroupsEndpointBuilderFactory.java`.
## Test plan
- [x] `mvn test` in `components/camel-jgroups` — all 18 tests pass.
- [x] Full reactor `mvn clean install -DskipTests` — succeeds, no other modules require updates.
---
_Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23510: camel-jgroups - align Exchange header constant names with Camel naming convention [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23209:
URL: https://github.com/apache/camel/pull/23209#issuecomment-4449087596
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23510: camel-jgroups - align Exchange header constant names with Camel naming convention [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23209:
URL: https://github.com/apache/camel/pull/23209#issuecomment-4449234807
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `catalog/camel-catalog`
- `components/camel-jgroups`
- `docs`
- `dsl/camel-endpointdsl`
<details><summary>All tested modules (10 modules)</summary>
- Camel :: Catalog :: Camel Catalog
- Camel :: Endpoint DSL
- Camel :: JBang :: MCP
- Camel :: JBang :: Plugin :: Route Parser
- Camel :: JBang :: Plugin :: TUI
- Camel :: JBang :: Plugin :: Validate
- Camel :: JGroups
- Camel :: Launcher :: Container
- Camel :: YAML DSL :: Validator
- Camel :: YAML DSL :: Validator Maven Plugin
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/25850526328)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23510: camel-jgroups - align Exchange header constant names with Camel naming convention [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #23209:
URL: https://github.com/apache/camel/pull/23209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org