You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Yann Ylavic <yl...@gmail.com> on 2019/02/20 13:25:27 UTC

Re: svn commit: r1853953 - /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c

On Wed, Feb 20, 2019 at 2:04 PM Ruediger Pluem <rp...@apache.org> wrote:
>
> Shouldn't we add (rb_method == RB_STREAM_CHUNKED) as condition to the above if as this only seems to make sense in the chunked encoding case?

Well, I think it makes no sense in both cases, but it was there in
stream_reqbody_cl() so I thought I'd keep it..

Regards,
Yann.

AW: svn commit: r1853953 - /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c

Posted by Plüm, Rüdiger, Vodafone Group <ru...@vodafone.com>.
My bad. I misread the diff. It was there in stream_reqbody_chunked and stream_reqbody_cl. So the condition is correct.

Regards

Rüdiger


C2 General

> -----Ursprüngliche Nachricht-----
> Von: Yann Ylavic <yl...@gmail.com>
> Gesendet: Mittwoch, 20. Februar 2019 14:25
> An: httpd-dev <de...@httpd.apache.org>
> Betreff: Re: svn commit: r1853953 -
> /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
> 
> On Wed, Feb 20, 2019 at 2:04 PM Ruediger Pluem <rp...@apache.org>
> wrote:
> >
> > Shouldn't we add (rb_method == RB_STREAM_CHUNKED) as condition to the
> above if as this only seems to make sense in the chunked encoding case?
> 
> Well, I think it makes no sense in both cases, but it was there in
> stream_reqbody_cl() so I thought I'd keep it..
> 
> Regards,
> Yann.