[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #2924: [ISSUE #1538] Fixes issue with integer-based for loop in BatchMessage.java

[GitBox <gi...@apache.org>]

jonyangx commented on code in PR #2924:
URL: https://github.com/apache/incubator-eventmesh/pull/2924#discussion_r1070187955


##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/grpc/protos/BatchMessage.java:
##########
@@ -1555,9 +1555,8 @@ public int getSerializedSize() {
                 (!getTopicBytes().isEmpty() ?
                         com.google.protobuf.GeneratedMessageV3.computeStringSize(3, topic_) : 0);
 
-        for (int i = 0; i < messageItem_.size(); i++) {
-            size += com.google.protobuf.CodedOutputStream
-                    .computeMessageSize(4, messageItem_.get(i));
+        for (MessageItem messageItem : messageItem_) {

Review Comment:
   @Orcohen33 suggest use reactor pattern ,use messageItem_.foreach().



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org