You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by András Piros via Review Board <no...@reviews.apache.org> on 2018/09/03 07:59:22 UTC
Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled
properly and failing MR job is treated as SUCCEEDED
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68237/
-----------------------------------------------------------
(Updated Sept. 3, 2018, 7:59 a.m.)
Review request for oozie, Andras Salamon, Attila Sasvari, Kinga Marton, and Peter Bacsko.
Changes
-------
More comments on `MapReduceActionExecutor` and `TestMapReduceActionExecutor` classes.
Repository: oozie-git
Description
-------
OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 8f0f244013932476d8ae454d224f235948529b34
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 83a23f5220aa72ba15edc8b98ef80a74213fcee8
core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java f39bba2c691435354dac6da7794e5142b511d937
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java a31079a41d30677d35a253a4a69505c21aa585f6
core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdComparator.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdFinder.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 893405e38ad71d22460768b76ed03ac4d9a0b95d
sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java f460b6bd11f60dfb397c6bba82be1427c2d1b570
Diff: https://reviews.apache.org/r/68237/diff/8/
Changes: https://reviews.apache.org/r/68237/diff/7-8/
Testing
-------
Tested on a real cluster, plus added test cases to `TestMapReduceActionExecutor` and new test classes.
Please note that I could find no proper way of actually getting MapReduce to start a new job while using `OozieClient#submit()` - apparently no YARN child application is created. Please advise what's the best way to advance, maybe call `JobClient#submitJob()` directly from `ActionExecutorTestCase#startWorkflowAndFailChildMRJob()`.
Thanks,
András Piros
Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled
properly and failing MR job is treated as SUCCEEDED
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68237/
-----------------------------------------------------------
(Updated Sept. 10, 2018, 3:37 p.m.)
Review request for oozie, Andras Salamon, Attila Sasvari, Kinga Marton, and Peter Bacsko.
Changes
-------
Addressing last FindBugs error.
Repository: oozie-git
Description
-------
OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 05fac3953eed5a5e2a16fa362656596f3a962a88
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 83a23f5220aa72ba15edc8b98ef80a74213fcee8
core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java f39bba2c691435354dac6da7794e5142b511d937
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java a31079a41d30677d35a253a4a69505c21aa585f6
core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdComparator.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdFinder.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 893405e38ad71d22460768b76ed03ac4d9a0b95d
sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java c9e2a914a4b88640ac1c370b8971355dc087a235
sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java f460b6bd11f60dfb397c6bba82be1427c2d1b570
Diff: https://reviews.apache.org/r/68237/diff/11/
Changes: https://reviews.apache.org/r/68237/diff/10-11/
Testing
-------
Tested on a real cluster, plus added test cases to `TestMapReduceActionExecutor` and new test classes.
Thanks,
András Piros
Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled
properly and failing MR job is treated as SUCCEEDED
Posted by Peter Bacsko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68237/#review208483
-----------------------------------------------------------
Ship it!
Ship It!
- Peter Bacsko
On szept. 7, 2018, 8:08 de, András Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68237/
> -----------------------------------------------------------
>
> (Updated szept. 7, 2018, 8:08 de)
>
>
> Review request for oozie, Andras Salamon, Attila Sasvari, Kinga Marton, and Peter Bacsko.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 05fac3953eed5a5e2a16fa362656596f3a962a88
> core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 83a23f5220aa72ba15edc8b98ef80a74213fcee8
> core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java f39bba2c691435354dac6da7794e5142b511d937
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java a31079a41d30677d35a253a4a69505c21aa585f6
> core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdComparator.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdFinder.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 893405e38ad71d22460768b76ed03ac4d9a0b95d
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java c9e2a914a4b88640ac1c370b8971355dc087a235
> sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java f460b6bd11f60dfb397c6bba82be1427c2d1b570
>
>
> Diff: https://reviews.apache.org/r/68237/diff/10/
>
>
> Testing
> -------
>
> Tested on a real cluster, plus added test cases to `TestMapReduceActionExecutor` and new test classes.
>
>
> Thanks,
>
> András Piros
>
>
Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled
properly and failing MR job is treated as SUCCEEDED
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68237/
-----------------------------------------------------------
(Updated Sept. 7, 2018, 8:08 a.m.)
Review request for oozie, Andras Salamon, Attila Sasvari, Kinga Marton, and Peter Bacsko.
Changes
-------
Addressing review comments.
Repository: oozie-git
Description
-------
OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 05fac3953eed5a5e2a16fa362656596f3a962a88
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 83a23f5220aa72ba15edc8b98ef80a74213fcee8
core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java f39bba2c691435354dac6da7794e5142b511d937
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java a31079a41d30677d35a253a4a69505c21aa585f6
core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdComparator.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdFinder.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 893405e38ad71d22460768b76ed03ac4d9a0b95d
sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java c9e2a914a4b88640ac1c370b8971355dc087a235
sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java f460b6bd11f60dfb397c6bba82be1427c2d1b570
Diff: https://reviews.apache.org/r/68237/diff/10/
Changes: https://reviews.apache.org/r/68237/diff/9-10/
Testing
-------
Tested on a real cluster, plus added test cases to `TestMapReduceActionExecutor` and new test classes.
Thanks,
András Piros
Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled
properly and failing MR job is treated as SUCCEEDED
Posted by András Piros via Review Board <no...@reviews.apache.org>.
> On Sept. 6, 2018, 9:42 p.m., Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java
> > Lines 377 (patched)
> > <https://reviews.apache.org/r/68237/diff/9/?file=2086198#file2086198line377>
> >
> > What's the reason for the list? Couldn't it be just an ApplicationId reference?
Moved from [`TestSubWorkflowActionExecutor`](https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java#L547-L568) for code reuse.
> On Sept. 6, 2018, 9:42 p.m., Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java
> > Lines 388 (patched)
> > <https://reviews.apache.org/r/68237/diff/9/?file=2086198#file2086198line388>
> >
> > Does that file contains only a single line? If so, this piece of code can be simplified.
Moved from [`TestSubWorkflowActionExecutor`](https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java#L547-L568) for code reuse.
> On Sept. 6, 2018, 9:42 p.m., Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdFinder.java
> > Lines 43 (patched)
> > <https://reviews.apache.org/r/68237/diff/9/?file=2086201#file2086201line43>
> >
> > Interesting... don't you need to add @RunWith(MockitoJunitRunner.class)? Does JUnit4 automatically handle @Mock members?
Indeed, instead of explicit `Mockito#mock()` calls now using `@RunWith(MockitoJUnitRunner.class)`.
- András
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68237/#review208426
-----------------------------------------------------------
On Sept. 6, 2018, 3:59 p.m., András Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68237/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2018, 3:59 p.m.)
>
>
> Review request for oozie, Andras Salamon, Attila Sasvari, Kinga Marton, and Peter Bacsko.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 05fac3953eed5a5e2a16fa362656596f3a962a88
> core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 83a23f5220aa72ba15edc8b98ef80a74213fcee8
> core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java f39bba2c691435354dac6da7794e5142b511d937
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java a31079a41d30677d35a253a4a69505c21aa585f6
> core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdComparator.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdFinder.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 893405e38ad71d22460768b76ed03ac4d9a0b95d
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java c9e2a914a4b88640ac1c370b8971355dc087a235
> sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java f460b6bd11f60dfb397c6bba82be1427c2d1b570
>
>
> Diff: https://reviews.apache.org/r/68237/diff/9/
>
>
> Testing
> -------
>
> Tested on a real cluster, plus added test cases to `TestMapReduceActionExecutor` and new test classes.
>
>
> Thanks,
>
> András Piros
>
>
Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled
properly and failing MR job is treated as SUCCEEDED
Posted by Peter Bacsko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68237/#review208426
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
Lines 541 (patched)
<https://reviews.apache.org/r/68237/#comment292333>
"NewYARN"
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
Lines 576-581 (patched)
<https://reviews.apache.org/r/68237/#comment292331>
This looks very complicated. Can't we just use Collections.sort() with passing the comparator?
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
Lines 647-657 (patched)
<https://reviews.apache.org/r/68237/#comment292334>
This is a separate class so that the Reader can be mocked in the tests, right?
core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java
Lines 377 (patched)
<https://reviews.apache.org/r/68237/#comment292336>
What's the reason for the list? Couldn't it be just an ApplicationId reference?
core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java
Lines 388 (patched)
<https://reviews.apache.org/r/68237/#comment292335>
Does that file contains only a single line? If so, this piece of code can be simplified.
core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdFinder.java
Lines 43 (patched)
<https://reviews.apache.org/r/68237/#comment292337>
Interesting... don't you need to add @RunWith(MockitoJunitRunner.class)? Does JUnit4 automatically handle @Mock members?
- Peter Bacsko
On szept. 6, 2018, 3:59 du, András Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68237/
> -----------------------------------------------------------
>
> (Updated szept. 6, 2018, 3:59 du)
>
>
> Review request for oozie, Andras Salamon, Attila Sasvari, Kinga Marton, and Peter Bacsko.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 05fac3953eed5a5e2a16fa362656596f3a962a88
> core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 83a23f5220aa72ba15edc8b98ef80a74213fcee8
> core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java f39bba2c691435354dac6da7794e5142b511d937
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java a31079a41d30677d35a253a4a69505c21aa585f6
> core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdComparator.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdFinder.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 893405e38ad71d22460768b76ed03ac4d9a0b95d
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java c9e2a914a4b88640ac1c370b8971355dc087a235
> sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java f460b6bd11f60dfb397c6bba82be1427c2d1b570
>
>
> Diff: https://reviews.apache.org/r/68237/diff/9/
>
>
> Testing
> -------
>
> Tested on a real cluster, plus added test cases to `TestMapReduceActionExecutor` and new test classes.
>
>
> Thanks,
>
> András Piros
>
>
Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled
properly and failing MR job is treated as SUCCEEDED
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68237/#review208444
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
Lines 576-581 (patched)
<https://reviews.apache.org/r/68237/#comment292365>
On the one hand we have an unordered `List<ApplicationId>` but in the reality we need only a `String` of the biggest `ApplicationId`.
Extracted method and written Javadoc to make the purpose clearer. Used `Iterables#transform()` and `Ordering#max()` for clarity.
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
Lines 647-657 (patched)
<https://reviews.apache.org/r/68237/#comment292367>
Yes. Added Javadoc to make it clearer.
- András Piros
On Sept. 6, 2018, 3:59 p.m., András Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68237/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2018, 3:59 p.m.)
>
>
> Review request for oozie, Andras Salamon, Attila Sasvari, Kinga Marton, and Peter Bacsko.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 05fac3953eed5a5e2a16fa362656596f3a962a88
> core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 83a23f5220aa72ba15edc8b98ef80a74213fcee8
> core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java f39bba2c691435354dac6da7794e5142b511d937
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java a31079a41d30677d35a253a4a69505c21aa585f6
> core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdComparator.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdFinder.java PRE-CREATION
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 893405e38ad71d22460768b76ed03ac4d9a0b95d
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java c9e2a914a4b88640ac1c370b8971355dc087a235
> sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java f460b6bd11f60dfb397c6bba82be1427c2d1b570
>
>
> Diff: https://reviews.apache.org/r/68237/diff/9/
>
>
> Testing
> -------
>
> Tested on a real cluster, plus added test cases to `TestMapReduceActionExecutor` and new test classes.
>
>
> Thanks,
>
> András Piros
>
>
Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled
properly and failing MR job is treated as SUCCEEDED
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68237/
-----------------------------------------------------------
(Updated Sept. 6, 2018, 3:59 p.m.)
Review request for oozie, Andras Salamon, Attila Sasvari, Kinga Marton, and Peter Bacsko.
Changes
-------
Changes:
* the class `YarnApplicationIdComparator` now considers also `ApplicationId` instances with different cluster timestamps as different
* refactored `MapReduceActionExecutor$YarnApplicationIdFinder#fallbackToYarnChildOrExternalId()` not to call `YarnClient#getApplications()` directly because of performance issues on a busy cluster. Instead, call `LauncherMain#getChildYarnApplications()` that calls `ClientRMProxy#getApplications(GetApplicationRequest request)` instead, for better filtering options. This way, performance doesn't suffer even on busy YARN clusters
Repository: oozie-git
Description
-------
OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 05fac3953eed5a5e2a16fa362656596f3a962a88
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 83a23f5220aa72ba15edc8b98ef80a74213fcee8
core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java f39bba2c691435354dac6da7794e5142b511d937
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java a31079a41d30677d35a253a4a69505c21aa585f6
core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdComparator.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdFinder.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 893405e38ad71d22460768b76ed03ac4d9a0b95d
sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java c9e2a914a4b88640ac1c370b8971355dc087a235
sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java f460b6bd11f60dfb397c6bba82be1427c2d1b570
Diff: https://reviews.apache.org/r/68237/diff/9/
Changes: https://reviews.apache.org/r/68237/diff/8-9/
Testing
-------
Tested on a real cluster, plus added test cases to `TestMapReduceActionExecutor` and new test classes.
Thanks,
András Piros
Re: Review Request 68237: OOZIE-3298 OYA: external ID is not filled
properly and failing MR job is treated as SUCCEEDED
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68237/
-----------------------------------------------------------
(Updated Sept. 3, 2018, 9:10 a.m.)
Review request for oozie, Andras Salamon, Attila Sasvari, Kinga Marton, and Peter Bacsko.
Repository: oozie-git
Description
-------
OOZIE-3298 OYA: external ID is not filled properly and failing MR job is treated as SUCCEEDED
Diffs
-----
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 8f0f244013932476d8ae454d224f235948529b34
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 83a23f5220aa72ba15edc8b98ef80a74213fcee8
core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java f39bba2c691435354dac6da7794e5142b511d937
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java a31079a41d30677d35a253a4a69505c21aa585f6
core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdComparator.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/hadoop/TestYarnApplicationIdFinder.java PRE-CREATION
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 893405e38ad71d22460768b76ed03ac4d9a0b95d
sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java f460b6bd11f60dfb397c6bba82be1427c2d1b570
Diff: https://reviews.apache.org/r/68237/diff/8/
Testing (updated)
-------
Tested on a real cluster, plus added test cases to `TestMapReduceActionExecutor` and new test classes.
Thanks,
András Piros