You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Billy Pearson (JIRA)" <ji...@apache.org> on 2007/12/29 21:47:43 UTC
[jira] Created: (HADOOP-2503) REST Insert / Select
REST Insert / Select
--------------------
Key: HADOOP-2503
URL: https://issues.apache.org/jira/browse/HADOOP-2503
Project: Hadoop
Issue Type: Bug
Components: contrib/hbase
Reporter: Billy Pearson
Priority: Critical
Fix For: 0.15.2
On inserts I submit the row key as urlencoded and its stored that way with the urlencodeing intact.
But when I select with rest I send the row key as urlencoded as I stored it and get nothing back. I thank the problem is the rest interfase is urldecodeing the request before looking up the data in the table. I can select with the urlencoded row key with the shell and get results.
This makes data not selectable if it has any urlencodeing chrs.
So 1 of two options I see
Make the insert store the row key after urldecode or make the select look up the row key the way it is submitted with out urldecodeing the key.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-2503) REST Insert / Select
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned HADOOP-2503:
-------------------------------------
Assignee: Bryan Duxbury
> REST Insert / Select
> --------------------
>
> Key: HADOOP-2503
> URL: https://issues.apache.org/jira/browse/HADOOP-2503
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Reporter: Billy Pearson
> Assignee: Bryan Duxbury
> Priority: Critical
> Fix For: 0.16.0
>
> Attachments: 2503.patch
>
>
> On inserts I submit the row key as urlencoded and its stored that way with the urlencodeing intact.
> But when I select with rest I send the row key as urlencoded as I stored it and get nothing back. I thank the problem is the rest interfase is urldecodeing the request before looking up the data in the table. I can select with the urlencoded row key with the shell and get results.
> This makes data not selectable if it has any urlencodeing chrs.
> So 1 of two options I see
> Make the insert store the row key after urldecode or make the select look up the row key the way it is submitted with out urldecodeing the key.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2503) REST Insert / Select
Posted by "Billy Pearson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554979 ]
Billy Pearson commented on HADOOP-2503:
---------------------------------------
Yes it fixed the problems.
I tested sending a urlencoded row key for insert/select/delete and all worked
Thanks
> REST Insert / Select
> --------------------
>
> Key: HADOOP-2503
> URL: https://issues.apache.org/jira/browse/HADOOP-2503
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Reporter: Billy Pearson
> Priority: Critical
> Fix For: 0.16.0
>
> Attachments: 2503.patch
>
>
> On inserts I submit the row key as urlencoded and its stored that way with the urlencodeing intact.
> But when I select with rest I send the row key as urlencoded as I stored it and get nothing back. I thank the problem is the rest interfase is urldecodeing the request before looking up the data in the table. I can select with the urlencoded row key with the shell and get results.
> This makes data not selectable if it has any urlencodeing chrs.
> So 1 of two options I see
> Make the insert store the row key after urldecode or make the select look up the row key the way it is submitted with out urldecodeing the key.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2503) REST Insert / Select
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-2503:
--------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed. Resolving. Thanks for the patch Bryan.
> REST Insert / Select
> --------------------
>
> Key: HADOOP-2503
> URL: https://issues.apache.org/jira/browse/HADOOP-2503
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Reporter: Billy Pearson
> Assignee: Bryan Duxbury
> Priority: Critical
> Fix For: 0.16.0
>
> Attachments: 2503.patch
>
>
> On inserts I submit the row key as urlencoded and its stored that way with the urlencodeing intact.
> But when I select with rest I send the row key as urlencoded as I stored it and get nothing back. I thank the problem is the rest interfase is urldecodeing the request before looking up the data in the table. I can select with the urlencoded row key with the shell and get results.
> This makes data not selectable if it has any urlencodeing chrs.
> So 1 of two options I see
> Make the insert store the row key after urldecode or make the select look up the row key the way it is submitted with out urldecodeing the key.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2503) REST Insert / Select
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HADOOP-2503:
----------------------------------
Status: Patch Available (was: Open)
Sending to Hudson.
> REST Insert / Select
> --------------------
>
> Key: HADOOP-2503
> URL: https://issues.apache.org/jira/browse/HADOOP-2503
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Reporter: Billy Pearson
> Priority: Critical
> Fix For: 0.16.0
>
> Attachments: 2503.patch
>
>
> On inserts I submit the row key as urlencoded and its stored that way with the urlencodeing intact.
> But when I select with rest I send the row key as urlencoded as I stored it and get nothing back. I thank the problem is the rest interfase is urldecodeing the request before looking up the data in the table. I can select with the urlencoded row key with the shell and get results.
> This makes data not selectable if it has any urlencodeing chrs.
> So 1 of two options I see
> Make the insert store the row key after urldecode or make the select look up the row key the way it is submitted with out urldecodeing the key.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2503) REST Insert / Select
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HADOOP-2503:
----------------------------------
Attachment: 2503.patch
Believe this fixes the problem. Billy, can you test and let me know if this takes care of it?
> REST Insert / Select
> --------------------
>
> Key: HADOOP-2503
> URL: https://issues.apache.org/jira/browse/HADOOP-2503
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Reporter: Billy Pearson
> Priority: Critical
> Fix For: 0.16.0
>
> Attachments: 2503.patch
>
>
> On inserts I submit the row key as urlencoded and its stored that way with the urlencodeing intact.
> But when I select with rest I send the row key as urlencoded as I stored it and get nothing back. I thank the problem is the rest interfase is urldecodeing the request before looking up the data in the table. I can select with the urlencoded row key with the shell and get results.
> This makes data not selectable if it has any urlencodeing chrs.
> So 1 of two options I see
> Make the insert store the row key after urldecode or make the select look up the row key the way it is submitted with out urldecodeing the key.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2503) REST Insert / Select
Posted by "Billy Pearson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Billy Pearson updated HADOOP-2503:
----------------------------------
Fix Version/s: (was: 0.15.2)
0.16.0
> REST Insert / Select
> --------------------
>
> Key: HADOOP-2503
> URL: https://issues.apache.org/jira/browse/HADOOP-2503
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Reporter: Billy Pearson
> Priority: Critical
> Fix For: 0.16.0
>
>
> On inserts I submit the row key as urlencoded and its stored that way with the urlencodeing intact.
> But when I select with rest I send the row key as urlencoded as I stored it and get nothing back. I thank the problem is the rest interfase is urldecodeing the request before looking up the data in the table. I can select with the urlencoded row key with the shell and get results.
> This makes data not selectable if it has any urlencodeing chrs.
> So 1 of two options I see
> Make the insert store the row key after urldecode or make the select look up the row key the way it is submitted with out urldecodeing the key.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2503) REST Insert / Select
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12555027 ]
Hadoop QA commented on HADOOP-2503:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12372333/2503.patch
against trunk revision r607330.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1437/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1437/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1437/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1437/console
This message is automatically generated.
> REST Insert / Select
> --------------------
>
> Key: HADOOP-2503
> URL: https://issues.apache.org/jira/browse/HADOOP-2503
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Reporter: Billy Pearson
> Assignee: Bryan Duxbury
> Priority: Critical
> Fix For: 0.16.0
>
> Attachments: 2503.patch
>
>
> On inserts I submit the row key as urlencoded and its stored that way with the urlencodeing intact.
> But when I select with rest I send the row key as urlencoded as I stored it and get nothing back. I thank the problem is the rest interfase is urldecodeing the request before looking up the data in the table. I can select with the urlencoded row key with the shell and get results.
> This makes data not selectable if it has any urlencodeing chrs.
> So 1 of two options I see
> Make the insert store the row key after urldecode or make the select look up the row key the way it is submitted with out urldecodeing the key.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (HADOOP-2503) REST Insert / Select
Posted by Bryan Duxbury <br...@rapleaf.com>.
It seems possible that it's not correctly decoding the keys on the
get/deletes. I will look into it when I get back to SF.
On Dec 29, 2007, at 12:51 PM, Billy Pearson (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/HADOOP-2503?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel#action_12554952 ]
>
> Billy Pearson commented on HADOOP-2503:
> ---------------------------------------
>
> I have not checked if deletes are effect by this should be tested
> also.
>
> I thank storing the data urldecoded would be the best solution so
> on every query we could just make sure the row key is urldecoded
> before running select/inserting/delete code.
>
>> REST Insert / Select
>> --------------------
>>
>> Key: HADOOP-2503
>> URL: https://issues.apache.org/jira/browse/
>> HADOOP-2503
>> Project: Hadoop
>> Issue Type: Bug
>> Components: contrib/hbase
>> Reporter: Billy Pearson
>> Priority: Critical
>> Fix For: 0.16.0
>>
>>
>> On inserts I submit the row key as urlencoded and its stored that
>> way with the urlencodeing intact.
>> But when I select with rest I send the row key as urlencoded as I
>> stored it and get nothing back. I thank the problem is the rest
>> interfase is urldecodeing the request before looking up the data
>> in the table. I can select with the urlencoded row key with the
>> shell and get results.
>> This makes data not selectable if it has any urlencodeing chrs.
>> So 1 of two options I see
>> Make the insert store the row key after urldecode or make the
>> select look up the row key the way it is submitted with out
>> urldecodeing the key.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Commented: (HADOOP-2503) REST Insert / Select
Posted by "Billy Pearson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554952 ]
Billy Pearson commented on HADOOP-2503:
---------------------------------------
I have not checked if deletes are effect by this should be tested also.
I thank storing the data urldecoded would be the best solution so on every query we could just make sure the row key is urldecoded before running select/inserting/delete code.
> REST Insert / Select
> --------------------
>
> Key: HADOOP-2503
> URL: https://issues.apache.org/jira/browse/HADOOP-2503
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Reporter: Billy Pearson
> Priority: Critical
> Fix For: 0.16.0
>
>
> On inserts I submit the row key as urlencoded and its stored that way with the urlencodeing intact.
> But when I select with rest I send the row key as urlencoded as I stored it and get nothing back. I thank the problem is the rest interfase is urldecodeing the request before looking up the data in the table. I can select with the urlencoded row key with the shell and get results.
> This makes data not selectable if it has any urlencodeing chrs.
> So 1 of two options I see
> Make the insert store the row key after urldecode or make the select look up the row key the way it is submitted with out urldecodeing the key.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.