You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/02/28 00:54:36 UTC

[PR] Correct VARIANT Logical Type annotation in Parquet examples [parquet-format]

alamb opened a new pull request, #555:
URL: https://github.com/apache/parquet-format/pull/555

   
   ### Rationale for this change
   - @wgtmac pointed out in https://github.com/apache/parquet-site/pull/171#discussion_r2845743793  
   
   That the example of the `VARAINT` type annotation in this repository did not have a version
   
   I double checked and the VARAINT logical type does indeed have a logical type: https://github.com/apache/parquet-format/blob/38818fa0e7efd54b535001a4448030a40619c2a3/src/main/thrift/parquet.thrift#L409-L413
   
   This is also consistent with the parquet-java tests:
   
   https://github.com/apache/parquet-java/blob/7148464a6b1a795f0058a811de2215d111b976ce/parquet-avro/src/test/java/org/apache/parquet/avro/TestReadVariant.java#L295
   
   https://github.com/apache/parquet-java/blob/7148464a6b1a795f0058a811de2215d111b976ce/parquet-column/src/test/java/org/apache/parquet/parser/TestParquetParser.java#L455
   
   ### What changes are included in this PR?
   
   Updated the representation of unshredded and shredded Variants in the example to include the variant version
   
   ### Do these changes have PoC implementations?
   
   No this does not change the spec at all, just the examples


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] Correct VARIANT Logical Type annotation in Parquet examples [parquet-format]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #555:
URL: https://github.com/apache/parquet-format/pull/555#issuecomment-4040938039

   Thanks again @wgtmac 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] Correct VARIANT Logical Type annotation in Parquet examples [parquet-format]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #555:
URL: https://github.com/apache/parquet-format/pull/555


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org