You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/06/23 06:28:30 UTC

[GitHub] [iotdb] choubenson opened a new pull request, #6394: [IOTDB-3608]Modify key of cache with new TsFile version rule

choubenson opened a new pull request, #6394:
URL: https://github.com/apache/iotdb/pull/6394

   Now bloomFilterCache, chunkCache and timeseriesMetadataCache is based on sg, version and compactionVersion as the key, and for now the version allows duplicates, which will cause  fetching a wrong bloomFilterCache.
   Solution: add timestamp of TsFile in the key.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] liuminghui233 commented on pull request #6394: [IOTDB-3608]Modify key of cache with new TsFile version rule

Posted by GitBox <gi...@apache.org>.
liuminghui233 commented on PR #6394:
URL: https://github.com/apache/iotdb/pull/6394#issuecomment-1170829296

   We should also modify `MergeReaderPriority` used in `PriorityMergeReader`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] liuminghui233 merged pull request #6394: [IOTDB-3608]Modify key of cache with new TsFile version rule

Posted by GitBox <gi...@apache.org>.
liuminghui233 merged PR #6394:
URL: https://github.com/apache/iotdb/pull/6394


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org