[GitHub] [libcloud] palashgandhi commented on a change in pull request #1596: EC2: Add support for gp3 and io2 volumes

[GitBox <gi...@apache.org>]

palashgandhi commented on a change in pull request #1596:
URL: https://github.com/apache/libcloud/pull/1596#discussion_r677936152



##########
File path: libcloud/compute/drivers/ec2.py
##########
@@ -2157,6 +2163,9 @@ def create_volume(self, size, name, location=None, snapshot=None,
             if ex_kms_key_id is not None:
                 params['KmsKeyId'] = ex_kms_key_id
 
+        if ex_volume_type == 'gp3' and ex_throughput:

Review comment:
       According to the [EC2 API reference](https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateVolume.html):
   
   >  Throughput
   > The throughput to provision for a volume, with a maximum of 1,000 MiB/s.
   > This parameter is valid only for gp3 volumes. 
   
   Are you seeing different behavior i.e. are you able to actually set the throughput for a volume type other than `gp3`? If so, the API reference might be outdated.
   
   Regarding iops, my change already has the following logic that should allow you to set `Iops` for io1, io2 and gp3 volumes:
   ```
       if ex_volume_type in ['io1', 'io2', 'gp3'] and ex_iops:
               params['Iops'] = ex_iops
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org