You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2017/08/17 17:06:07 UTC

[GitHub] activemq-artemis issue #1469: ARTEMIS-1355 Default config for client reconne...

Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1469
  
    So this is kind of weird.  Awhile back you sent #1438 to "correct" the doc from 0 to -1.  Now you're sending this PR to "correct" the code from 0 to -1.
    
    As far as I can tell the original #1438 shouldn't have been merged as it was incorrectly based on the default reconnect-attempts for *cluster-connection*.
    
    The default reconnect-attempts for a normal client connection should be 0 (which it is currently in the code, and used to be in the doc).
    
    I believe this PR should be closed and a new one should be raised to fix what #1438 broke.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---