You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2018/04/24 17:44:57 UTC

[GitHub] carbondata pull request #2210: [WIP] [CARBONDATA-2381] Improve compaction pe...

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2210#discussion_r183822226
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/ResultCollectorFactory.java ---
    @@ -45,31 +46,37 @@
        * @return
        */
       public static AbstractScannedResultCollector getScannedResultCollector(
    -      BlockExecutionInfo blockExecutionInfo) {
    +      BlockExecutionInfo blockExecutionInfo, QueryStatisticsModel queryStatisticsModel) {
    --- End diff --
    
    Instead of changing constructor, can we add statistics model to block execution info??


---