You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ma...@apache.org on 2022/03/29 16:21:26 UTC

[camel-karavan] branch main updated: Fix #251 (#253)

This is an automated email from the ASF dual-hosted git repository.

marat pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-karavan.git


The following commit(s) were added to refs/heads/main by this push:
     new f5f5433  Fix #251 (#253)
f5f5433 is described below

commit f5f54333e5a0b56679bd999bfabaca603bc32c39
Author: Marat Gubaidullin <ma...@gmail.com>
AuthorDate: Tue Mar 29 12:21:22 2022 -0400

    Fix #251 (#253)
---
 karavan-designer/src/designer/route/property/DslPropertyField.tsx | 8 +++++++-
 karavan-vscode/webview/index.css                                  | 2 +-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/karavan-designer/src/designer/route/property/DslPropertyField.tsx b/karavan-designer/src/designer/route/property/DslPropertyField.tsx
index 9f4d656..3e1f0d7 100644
--- a/karavan-designer/src/designer/route/property/DslPropertyField.tsx
+++ b/karavan-designer/src/designer/route/property/DslPropertyField.tsx
@@ -449,7 +449,12 @@ export class DslPropertyField extends React.Component<Props, State> {
                     position={"left"}
                     headerContent={property.displayName}
                     bodyContent={property.description}
-                    footerContent={property.defaultValue !== undefined ? "Default: " + property.defaultValue : undefined}>
+                    footerContent={
+                    <div>
+                        {property.defaultValue !== undefined && property.defaultValue.toString().trim().length >0 && <div>{"Default: " + property.defaultValue}</div>}
+                        {property.required && <b>Required</b>}
+                    </div>
+                    }>
                     <button type="button" aria-label="More info" onClick={e => {
                         e.preventDefault();
                         e.stopPropagation();
@@ -474,6 +479,7 @@ export class DslPropertyField extends React.Component<Props, State> {
         return (
             <FormGroup
                 label={this.props.hideLabel ? undefined : this.getLabel(property, value)}
+                isRequired={property.required}
                 fieldId={property.name}
                 labelIcon={this.getLabelIcon(property)}>
                 {value && ["ExpressionDefinition", "ExpressionSubElementDefinition"].includes(property.type)
diff --git a/karavan-vscode/webview/index.css b/karavan-vscode/webview/index.css
index 72cd3d1..c06efb1 100644
--- a/karavan-vscode/webview/index.css
+++ b/karavan-vscode/webview/index.css
@@ -248,7 +248,7 @@ body, :root, #root, .karavan {
 }
 
 .vscode-dark .pf-c-tooltip {
-  --pf-c-tooltip__content--BackgroundColor: var(--vscode-tab-activeBackground);
+  --pf-c-tooltip__content--BackgroundColor: var(--vscode-input-background);
 }
 
 /* Modal */