You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ni...@apache.org on 2007/11/16 15:27:14 UTC
svn commit: r595678 - /httpd/httpd/trunk/modules/http/http_filters.c
Author: niq
Date: Fri Nov 16 06:27:11 2007
New Revision: 595678
URL: http://svn.apache.org/viewvc?rev=595678&view=rev
Log:
r595672 was incomplete. We need to be sure we reject multiple-encodings.
Modified:
httpd/httpd/trunk/modules/http/http_filters.c
Modified: httpd/httpd/trunk/modules/http/http_filters.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_filters.c?rev=595678&r1=595677&r2=595678&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/http/http_filters.c (original)
+++ httpd/httpd/trunk/modules/http/http_filters.c Fri Nov 16 06:27:11 2007
@@ -116,7 +116,7 @@
if (tenc) {
/* RFC2616 allows qualifiers, so use strncasecmp */
- if (!strncasecmp(tenc, "chunked", 7)) {
+ if (!strncasecmp(tenc, "chunked", 7) && !ap_strchr_c(tenc, ',')) {
ctx->state = BODY_CHUNK;
}
else {
Re: svn commit: r595678 - /httpd/httpd/trunk/modules/http/http_filters.c
Posted by Ruediger Pluem <rp...@apache.org>.
On 11/16/2007 03:27 PM, niq@apache.org wrote:
> Author: niq
> Date: Fri Nov 16 06:27:11 2007
> New Revision: 595678
>
> URL: http://svn.apache.org/viewvc?rev=595678&view=rev
> Log:
> r595672 was incomplete. We need to be sure we reject multiple-encodings.
>
> Modified:
> httpd/httpd/trunk/modules/http/http_filters.c
>
> Modified: httpd/httpd/trunk/modules/http/http_filters.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_filters.c?rev=595678&r1=595677&r2=595678&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/http/http_filters.c (original)
> +++ httpd/httpd/trunk/modules/http/http_filters.c Fri Nov 16 06:27:11 2007
> @@ -116,7 +116,7 @@
>
> if (tenc) {
> /* RFC2616 allows qualifiers, so use strncasecmp */
> - if (!strncasecmp(tenc, "chunked", 7)) {
> + if (!strncasecmp(tenc, "chunked", 7) && !ap_strchr_c(tenc, ',')) {
I agree that as already mentioned by you and Björn in the PR it should be strcasecmp(tenc, "chunked") again.
Regards
Rüdiger