You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2020/03/30 07:23:36 UTC

[kudu-CR] [ranger] fix authorizing list tables 

Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15592


Change subject: [ranger] fix authorizing list tables
......................................................................

[ranger] fix authorizing list tables

When authorizing list tables and there is no tables in Kudu, we should
return 'OK' instead of 'InvalidArgument' error.

Change-Id: I2a4dfe61e85fc21d67e6422a1cdb36d887d51f4f
---
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
2 files changed, 8 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/15592/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a4dfe61e85fc21d67e6422a1cdb36d887d51f4f
Gerrit-Change-Number: 15592
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>

[kudu-CR] [ranger] fix authorizing list tables

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15592 )

Change subject: [ranger] fix authorizing list tables
......................................................................

[ranger] fix authorizing list tables

When authorizing list tables and there is no tables in Kudu, we should
return 'OK' instead of 'InvalidArgument' error.

Change-Id: I2a4dfe61e85fc21d67e6422a1cdb36d887d51f4f
Reviewed-on: http://gerrit.cloudera.org:8080/15592
Reviewed-by: Attila Bukor <ab...@apache.org>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
2 files changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Attila Bukor: Looks good to me, approved
  Andrew Wong: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a4dfe61e85fc21d67e6422a1cdb36d887d51f4f
Gerrit-Change-Number: 15592
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [ranger] fix authorizing list tables

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15592 )

Change subject: [ranger] fix authorizing list tables
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a4dfe61e85fc21d67e6422a1cdb36d887d51f4f
Gerrit-Change-Number: 15592
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 30 Mar 2020 07:37:02 +0000
Gerrit-HasComments: No

[kudu-CR] [ranger] fix authorizing list tables

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15592 )

Change subject: [ranger] fix authorizing list tables
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a4dfe61e85fc21d67e6422a1cdb36d887d51f4f
Gerrit-Change-Number: 15592
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 30 Mar 2020 07:29:30 +0000
Gerrit-HasComments: No