You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Tim Smith (JIRA)" <ji...@apache.org> on 2009/05/01 15:36:30 UTC

[jira] Created: (LUCENE-1625) openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus

openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus
---------------------------------------------------------------------

                 Key: LUCENE-1625
                 URL: https://issues.apache.org/jira/browse/LUCENE-1625
             Project: Lucene - Java
          Issue Type: Bug
          Components: Index
    Affects Versions: 2.4
            Reporter: Tim Smith


When using CheckIndex programatically, the openReaderPassed flag on the SegmentInfoStatus is never populated (so it always comes back false)

looking at the code, its clear that openReaderPassed is defined, but never used

furthermore, it appears that not all information that is propagated to the "InfoStream" is available via SegmentIinfoStatus

All of the following information should be able to be gather from public properties on the SegmentInfoStatus:
test: open reader.........OK
test: fields, norms.......OK [2 fields]
test: terms, freq, prox...OK [101 terms; 133 terms/docs pairs; 133 tokens]
test: stored fields.......OK [100 total field count; avg 1 fields per doc]
test: term vectors........OK [0 total vector count; avg 0 term/freq vector fields per doc]


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1625) openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707650#action_12707650 ] 

Michael McCandless commented on LUCENE-1625:
--------------------------------------------

OK I committed a fix for openReaderPassed.  Thanks Tim!

Could you (or, anyone, but since you seem to have the itch...) create a patch for the further details you'd like returned?

> openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-1625
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1625
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.4
>            Reporter: Tim Smith
>
> When using CheckIndex programatically, the openReaderPassed flag on the SegmentInfoStatus is never populated (so it always comes back false)
> looking at the code, its clear that openReaderPassed is defined, but never used
> furthermore, it appears that not all information that is propagated to the "InfoStream" is available via SegmentIinfoStatus
> All of the following information should be able to be gather from public properties on the SegmentInfoStatus:
> test: open reader.........OK
> test: fields, norms.......OK [2 fields]
> test: terms, freq, prox...OK [101 terms; 133 terms/docs pairs; 133 tokens]
> test: stored fields.......OK [100 total field count; avg 1 fields per doc]
> test: term vectors........OK [0 total vector count; avg 0 term/freq vector fields per doc]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Assigned: (LUCENE-1625) openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless reassigned LUCENE-1625:
------------------------------------------

    Assignee: Michael McCandless

> openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-1625
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1625
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.4
>            Reporter: Tim Smith
>            Assignee: Michael McCandless
>             Fix For: 2.9
>
>         Attachments: CheckIndex.patch
>
>
> When using CheckIndex programatically, the openReaderPassed flag on the SegmentInfoStatus is never populated (so it always comes back false)
> looking at the code, its clear that openReaderPassed is defined, but never used
> furthermore, it appears that not all information that is propagated to the "InfoStream" is available via SegmentIinfoStatus
> All of the following information should be able to be gather from public properties on the SegmentInfoStatus:
> test: open reader.........OK
> test: fields, norms.......OK [2 fields]
> test: terms, freq, prox...OK [101 terms; 133 terms/docs pairs; 133 tokens]
> test: stored fields.......OK [100 total field count; avg 1 fields per doc]
> test: term vectors........OK [0 total vector count; avg 0 term/freq vector fields per doc]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1625) openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-1625.
----------------------------------------

    Resolution: Fixed

Thanks Tim!

> openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-1625
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1625
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.4
>            Reporter: Tim Smith
>            Assignee: Michael McCandless
>             Fix For: 2.9
>
>         Attachments: CheckIndex.patch
>
>
> When using CheckIndex programatically, the openReaderPassed flag on the SegmentInfoStatus is never populated (so it always comes back false)
> looking at the code, its clear that openReaderPassed is defined, but never used
> furthermore, it appears that not all information that is propagated to the "InfoStream" is available via SegmentIinfoStatus
> All of the following information should be able to be gather from public properties on the SegmentInfoStatus:
> test: open reader.........OK
> test: fields, norms.......OK [2 fields]
> test: terms, freq, prox...OK [101 terms; 133 terms/docs pairs; 133 tokens]
> test: stored fields.......OK [100 total field count; avg 1 fields per doc]
> test: term vectors........OK [0 total vector count; avg 0 term/freq vector fields per doc]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1625) openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus

Posted by "Tim Smith (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Smith updated LUCENE-1625:
------------------------------

    Attachment: CheckIndex.patch

Attached patch for exposing all collected stats
(created with svn diff > CheckIndex.patch (please correct me if this is not the right way (this is my first patch)))


This patch breaks out the testing of field norms, terms, stored fields, and term vectors into their own methods
it also creates a status object for each one of these tests to make the results transparent

this status object exposes:
* stats previously only available from infoStream
* exception thrown if test fails (null if test was successful)

each SegmentInfoStatus will have these status objects attached

NOTE:
This patch allows that if one of the above tests fails, it will attempt to keep testing (to find all failures)
any failure will still result in the overall segment being rejected

> openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-1625
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1625
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.4
>            Reporter: Tim Smith
>         Attachments: CheckIndex.patch
>
>
> When using CheckIndex programatically, the openReaderPassed flag on the SegmentInfoStatus is never populated (so it always comes back false)
> looking at the code, its clear that openReaderPassed is defined, but never used
> furthermore, it appears that not all information that is propagated to the "InfoStream" is available via SegmentIinfoStatus
> All of the following information should be able to be gather from public properties on the SegmentInfoStatus:
> test: open reader.........OK
> test: fields, norms.......OK [2 fields]
> test: terms, freq, prox...OK [101 terms; 133 terms/docs pairs; 133 tokens]
> test: stored fields.......OK [100 total field count; avg 1 fields per doc]
> test: term vectors........OK [0 total vector count; avg 0 term/freq vector fields per doc]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1625) openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724106#action_12724106 ] 

Michael McCandless commented on LUCENE-1625:
--------------------------------------------

This patch is awesome, Tim; thanks!  I will commit in a day or two.

> openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-1625
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1625
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.4
>            Reporter: Tim Smith
>             Fix For: 2.9
>
>         Attachments: CheckIndex.patch
>
>
> When using CheckIndex programatically, the openReaderPassed flag on the SegmentInfoStatus is never populated (so it always comes back false)
> looking at the code, its clear that openReaderPassed is defined, but never used
> furthermore, it appears that not all information that is propagated to the "InfoStream" is available via SegmentIinfoStatus
> All of the following information should be able to be gather from public properties on the SegmentInfoStatus:
> test: open reader.........OK
> test: fields, norms.......OK [2 fields]
> test: terms, freq, prox...OK [101 terms; 133 terms/docs pairs; 133 tokens]
> test: stored fields.......OK [100 total field count; avg 1 fields per doc]
> test: term vectors........OK [0 total vector count; avg 0 term/freq vector fields per doc]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1625) openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-1625:
---------------------------------------

    Fix Version/s: 2.9

> openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-1625
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1625
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.4
>            Reporter: Tim Smith
>             Fix For: 2.9
>
>         Attachments: CheckIndex.patch
>
>
> When using CheckIndex programatically, the openReaderPassed flag on the SegmentInfoStatus is never populated (so it always comes back false)
> looking at the code, its clear that openReaderPassed is defined, but never used
> furthermore, it appears that not all information that is propagated to the "InfoStream" is available via SegmentIinfoStatus
> All of the following information should be able to be gather from public properties on the SegmentInfoStatus:
> test: open reader.........OK
> test: fields, norms.......OK [2 fields]
> test: terms, freq, prox...OK [101 terms; 133 terms/docs pairs; 133 tokens]
> test: stored fields.......OK [100 total field count; avg 1 fields per doc]
> test: term vectors........OK [0 total vector count; avg 0 term/freq vector fields per doc]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1625) openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus

Posted by "Tim Smith (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708002#action_12708002 ] 

Tim Smith commented on LUCENE-1625:
-----------------------------------

I will work up a patch if i am able to find the time, currently, as a workaround, i am just setting the infostream to System.stderr when a "verbose" output is needed (which is acceptable for my current use)


> openReaderPassed not populated in CheckIndex.Status.SegmentInfoStatus
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-1625
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1625
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.4
>            Reporter: Tim Smith
>
> When using CheckIndex programatically, the openReaderPassed flag on the SegmentInfoStatus is never populated (so it always comes back false)
> looking at the code, its clear that openReaderPassed is defined, but never used
> furthermore, it appears that not all information that is propagated to the "InfoStream" is available via SegmentIinfoStatus
> All of the following information should be able to be gather from public properties on the SegmentInfoStatus:
> test: open reader.........OK
> test: fields, norms.......OK [2 fields]
> test: terms, freq, prox...OK [101 terms; 133 terms/docs pairs; 133 tokens]
> test: stored fields.......OK [100 total field count; avg 1 fields per doc]
> test: term vectors........OK [0 total vector count; avg 0 term/freq vector fields per doc]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org